Skip to content

fix: remove duplicate skills input field in templates/index.html#284

Closed
Harshada-Yele wants to merge 1 commit into
komalharshita:mainfrom
Harshada-Yele:feat/autocomplete-off-skills-input
Closed

fix: remove duplicate skills input field in templates/index.html#284
Harshada-Yele wants to merge 1 commit into
komalharshita:mainfrom
Harshada-Yele:feat/autocomplete-off-skills-input

Conversation

@Harshada-Yele

@Harshada-Yele Harshada-Yele commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Removed a duplicate element with id="skills-input" from
templates/index.html. Two input fields with the same ID is invalid
HTML and causes accessibility issues.

Related Issue

Closes #258

Type of Change

  • Bug fix — resolves a broken behaviour
  • Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed

File Change made
templates/index.html Removed duplicate skills input element

How to Test This PR

  1. Clone this branch: git checkout feat/autocomplete-off-skills-input
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000
  5. Inspect the skills input field using browser DevTools
  6. Verify only one input with id="skills-input" exists in the DOM
  7. Run the tests: python tests/test_basic.py

Expected test output:

30 passed, out of 30 tests

Test Results [required]

image

Screenshots

Before After

|
Screenshot 2026-05-18 150053
|
Screenshot 2026-05-18 150145
|

Self-Review Checklist

  • I have read CONTRIBUTING.md and followed all guidelines
  • I have run python tests/test_basic.py and all tests pass
  • I have not introduced any print() or console.log() debug statements
  • I have not modified files outside the scope of the linked issue
  • If I changed the UI, I tested it at 375px mobile and 1280px desktop

Notes for Reviewer

The skills input field had two identical id="skills-input" elements.
Duplicate IDs are invalid HTML per W3C specification. The incomplete
duplicate was removed, keeping the complete input that includes
aria-haspopup, aria-expanded, and aria-controls attributes.

@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown

@Harshada-Yele is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Harshada-Yele

Copy link
Copy Markdown
Contributor Author

Hi @komalharshita
PR Ready to review
#258

@komalharshita

Copy link
Copy Markdown
Owner

@Harshada-Yele kindly ensure all the checks pass before merging

@Harshada-Yele

Harshada-Yele commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Hi @komalharshita
test_health_check has a pre-existing fixture bug unrelated
to this PR. Due to which the test fails
A separate issue is raised for it. #273

@Harshada-Yele Harshada-Yele force-pushed the feat/autocomplete-off-skills-input branch from 5f455a5 to b66ad7d Compare May 19, 2026 03:25
@Harshada-Yele

Copy link
Copy Markdown
Contributor Author

Hi @komalharshita
All the checks pass
Ready for Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add autocomplete="off" to skills input to prevent browser autocomplete interference

2 participants