fix: remove duplicate skills input field in templates/index.html#284
Open
Harshada-Yele wants to merge 1 commit into
Open
fix: remove duplicate skills input field in templates/index.html#284Harshada-Yele wants to merge 1 commit into
Harshada-Yele wants to merge 1 commit into
Conversation
|
@Harshada-Yele is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hi @komalharshita |
Open
2 tasks
Owner
|
@Harshada-Yele kindly ensure all the checks pass before merging |
Contributor
Author
|
Hi @komalharshita |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed a duplicate element with id="skills-input" from
templates/index.html. Two input fields with the same ID is invalid
HTML and causes accessibility issues.
Related Issue
Closes #258
Type of Change
data/projects.jsonWhat Was Changed
templates/index.htmlHow to Test This PR
git checkout feat/autocomplete-off-skills-inputpip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots
|


|
|
Self-Review Checklist
Notes for Reviewer
The skills input field had two identical id="skills-input" elements.
Duplicate IDs are invalid HTML per W3C specification. The incomplete
duplicate was removed, keeping the complete input that includes
aria-haspopup, aria-expanded, and aria-controls attributes.
test_health_checkhas a pre-existing fixture bug unrelatedto this PR. A separate issue should be raised for it.