Improve skill input UX with shared skill dataset and autocomplete dropdown#50
Conversation
|
@PraneshJha1038 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@komalharshita Have a look at the pr, and also please merge after 15th if satisfied. |
komalharshita
left a comment
There was a problem hiding this comment.
Excellent work on this PR. This is a meaningful UX improvement and the implementation is thoughtfully done.
The autocomplete flow, keyboard navigation, duplicate prevention, accessibility handling, and shared dataset structure are all well implemented. The ARIA support and interaction handling especially stand out.
Before future PRs, try to avoid unrelated formatting/whitespace changes since they make reviews harder to follow. Apart from that, this is a strong contribution and aligns well with the issue requirements.
Approved for merge.
…pdown
Summary [required]
This PR improves the skill selection workflow by introducing a dataset-driven autocomplete system for skills input.
Previously, the input allowed unrestricted free-text entries, which could lead to:
React,reactjs,react-js)The new implementation improves consistency, usability, and overall recommendation quality through guided skill selection.
Related Issue [required]
Closes #37
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
static/script.jsArrowUp,ArrowDown,Enter,Escape) - click-to-select interactions - duplicate skill prevention - auto-add for pending typed input on submit - canonical label normalizationtemplates/index.htmltemplates/index.htmlstatic/data/skills.jsbeforestatic/script.jsscripts/data/skills.jsstatic/style.cssHow to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pyfind your next projectsectionFlask, or any other skillarrow up,arrow down,escandenterpython tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots (if UI change)
|

|
|
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This PR strongly improves consistency and guidance, but it does not fully hard-block unknown free-text entries yet. If strict validation against the approved skill list is required, that would be a follow-up change post merging of this PR.