Adding a live skill search filter to the results section#65
Adding a live skill search filter to the results section#6522oo1cso56mansoorkhan-cell wants to merge 4 commits into
Conversation
|
@22oo1cso56mansoorkhan-cell is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the contribution — this is a meaningful UX improvement and the live filtering behavior works well overall.
Before this PR can be approved, a few important changes are still needed:
-
Please resolve the current merge conflicts with the latest
mainbranch. -
The PR should properly link the issue using:
Closes #8
instead of only mentioning#8. -
The search input currently has no accessibility support. Please add either:
- a proper
<label>
or - an
aria-label
- The issue specifically mentions a skill search filter, but the current implementation only filters by project title and description. Please extend the filtering logic to also search project skills/tags.
Once these changes are addressed, the PR will be much closer to merge-ready.
|
I have done the given required changes @komalharshita you can review now..... |
|
@22oo1cso56mansoorkhan-cell kindly resolve the merge conflicts before merging |
|
@komalharshita could U please help me out with that Merging conflicts..I have tried a lot but still Conflicts are there |
|
@22oo1cso56mansoorkhan-cell sync your branch with the main branch |
|
@komalharshita I have resolved the merge conflicts ...Thanks for the help👍..You can review now |
Summary [required]
with this pr, we are getting a search option which enables us to search the result by typing the title and description on fucus , no delay.
Related Issue [required]
Closes #8
Changes made:
Technical implementation:
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
template/index.htmlstatic/style.cssstatic/script.jsHow to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
'''
27 passed, 0 failed out of 27 tests
'''
Test Results [required]
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
None