fix: add missing 500 error template#67
Merged
komalharshita merged 1 commit intoMay 16, 2026
Merged
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
Contributor
Author
|
@komalharshita Kindly review and merge |
komalharshita
approved these changes
May 16, 2026
Owner
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for addressing the requested changes.
This is a solid bug-fix PR overall. The issue is legitimate, the implementation is properly scoped, and the added regression test is especially valuable because it prevents the 500.html missing-template issue from reappearing in future changes.
I also appreciate that the PR stays focused only on the relevant files without introducing unrelated modifications.
The implementation and test coverage look good to merge. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
This PR fixes the registered internal server error handler by adding the missing
templates/500.htmlpage. Without this template, Flask can raise a secondaryTemplateNotFound: 500.htmlerror when handling an unexpected server error. The new page follows the same structure as the existing404.htmltemplate and includes a regression test for the 500 handler.Related Issue [required]
Closes #66
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
templates/500.htmltests/test_basic.pyHow to Test This PR [required]
git checkout fix/missing-500-templatepip install -r requirements.txtpython tests/test_basic.pypython app.pyand trigger an unhandled server-side exception locally to confirm the friendly 500 page renders.Expected test output:
Test Results [required]
Screenshots (if UI change)
No screenshot attached. This adds the missing error template and verifies it through the regression test.
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
python -m flake8 .currently reports pre-existing lint issues across unrelated files such asroutes/main_routes.py,starter_code/*, and existing tests. I did not modify those files to keep this PR scoped to issue #66.