feat: allow deselecting selected skill chips by clicking again#69
Conversation
|
@peeyoush is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Resolved the merge conflict issues after syncing with the latest Verified flows:
|
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the thoughtful implementation and for keeping the changes cleanly scoped to the skill chip interaction logic.
I reviewed the behavior carefully, including the toggle handling, duplicate prevention, and synchronization flow. The updated interaction feels much more intuitive, especially for touch/mobile usage, while preserving the existing remove-button functionality.
The implementation is well-contained, avoids unnecessary file changes, and the conflict resolution/update verification was handled properly.
Approved for merge.
Summary [required]
This PR improves the skill selection interaction on the homepage by allowing already-selected popular skill chips to be deselected when clicked again.
Previously, users could only remove a selected skill by clicking the small “×” button inside the selected tag. This change makes the interaction more intuitive and touch-friendly, especially on smaller screens or during quick interactions.
The existing UI and remove button behavior remain unchanged — this update only improves the interaction logic and keeps the selected chip state synchronized properly.
Related Issue [required]
Closes #28
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
static/script.jsstatic/script.jsstatic/script.jsHow to Test This PR [required]
Clone this branch:
git checkout feat/skill-chip-toggleInstall dependencies:
pip install -r requirements.txtRun the app:
python app.pyOpen:
http://127.0.0.1:5000Verify the following:
Run the tests:
python tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots (if UI change)
|


|
|
Self-Review Checklist [required]
CONTRIBUTING.mdand followed all guidelinesfeat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statements375px(mobile) and1280px(desktop)Notes for Reviewer
Ran
flake8 .locally and observed several existing linting issues in unrelated repository files. No new linting issues were introduced by this PR.This PR is scoped only to the skill chip interaction enhancement in
static/script.js.