Redirection links fixed#70
Conversation
|
@Lalitya31 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR addresses broken footer/navigation GitHub redirections and adds an in-page “Our Story / About Us” section on the homepage to prevent “About Us / Our Story” from incorrectly linking out to GitHub.
Changes:
- Updated GitHub links in the homepage and project detail templates to point to the DevPath repository (and related resources like issues/CONTRIBUTING/LICENSE).
- Added an “Our Story / About Us” section on the homepage and wired footer links to the
#our-storyanchor. - Added a
package-lock.jsonfile to the repository.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| templates/project.html | Updates header/footer GitHub links away from https://github.com to the project repository. |
| templates/index.html | Updates GitHub/resource links and adds an “Our Story” section with footer navigation to #our-story. |
| package-lock.json | Introduces an npm lockfile (currently without a corresponding package.json). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@komalharshita this PR is ready for review and merge since 2 days. Thank you :) |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the contribution — the navigation fixes and “Our Story” section are well implemented and improve the UX significantly.
The GitHub/resource redirects are now correctly scoped to the repository, and the footer navigation behavior is much more consistent across pages.
Before merge, there is one important cleanup required:
Requested Change
Please remove the package-lock.json file from this PR.
The repository currently does not appear to use npm/package-based tooling, and this file is unrelated to the linked issue. Keeping the PR scoped only to the routing/navigation fixes will make the contribution cleaner and easier to maintain.
Once that file is removed, this PR should be ready for approval.
|
@komalharshita Removed the unrelated package-lock.json |
|
@Lalitya31 kindly resolve the merge conflicts |
|
@komalharshita resolved. i hope no issues now |
|
approved for merge |
Summary [required]
Related Issue [required]
Closes #45
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
templates/index.htmltemplates/project.htmlHow to Test This PR [required]
git checkout gitlinkpip install -r requirements.txtpython app.pypython tests/test_basic.pyTest Results [required]
redirection to pages works
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
None