data: add three new beginner-level projects to dataset#72
Conversation
Signed-off-by: sagun bajpai <sagunbajpaisagun@gmail.com>
|
@Sagun-Bajpai is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the contribution — this is a well-structured dataset expansion overall. I appreciate that you not only added new project entries, but also included matching starter templates and kept the JSON schema consistent across all projects.
The Games and Automation categories are also a good addition since they improve project diversity for beginners.
Before merge, there are two improvements needed:
- In
starter_code/email_automation.py, the example usage currently includes:
send_email("your@gmail.com", "yourpassword", ...)Even though these are placeholders, it encourages hardcoded credential patterns for beginners. Please replace this with a safer example approach (environment variables, input prompts, or commented placeholders).
starter_code/quiz_app.htmlis currently very minimal and mostly TODO comments. Please add a slightly stronger starter scaffold (basic buttons/question structure/score section) so contributors have a more meaningful starting point.
Once these are updated, this PR will be in a strong state for merge.
Signed-off-by: sagun bajpai <sagunbajpaisagun@gmail.com>
4b0da12 to
cece343
Compare
|
Hi @komalharshita 👋 I have made both the requested changes:
All 27 tests passing. Please review when you get a chance. Thank you! 😊 |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for addressing the earlier review feedback. The PR is now in a much stronger state.
The dataset additions are well-structured, educationally useful, and improve beginner project diversity in the Games and Automation categories. I also appreciate that the matching starter templates were included and kept consistent with the existing schema/style of the repository.
The previously raised concerns were handled well:
- the email automation example now avoids insecure hardcoded credential patterns
- the quiz app starter scaffold is now much more meaningful for beginners
The implementation remains properly scoped to dataset/template additions without introducing unrelated modifications, which keeps maintenance risk low.
Overall, this is now a solid contribution and merge-ready.
Approved for merge.
Summary [required]
This PR adds three new beginner-level projects to the dataset to give users more project options, especially in underrepresented interest areas like Games and Automation. Three new entries have been added to data/projects.json along with their starter code templates.
Related Issue [required]
Closes #4
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
data/projects.jsonstarter_code/number_guessing.pystarter_code/email_automation.pystarter_code/quiz_app.htmlHow to Test This PR [required]
git checkout data/add-three-beginner-projectspip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output: