Skip to content

PG4+ support#2

Open
alitrack wants to merge 2 commits into
komamitsu:masterfrom
alitrack:master
Open

PG4+ support#2
alitrack wants to merge 2 commits into
komamitsu:masterfrom
alitrack:master

Conversation

@alitrack

Copy link
Copy Markdown

No description provided.

@komamitsu komamitsu self-requested a review December 14, 2023 14:30

@komamitsu komamitsu left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alitrack Thanks for the contribution! I left a few minor comments. Can you take a look at them?

Comment thread foreign_table_exposer.c
#if PG14_LT
fte_post_parse_analyse(ParseState *pstate, Query *query)
#else
fte_post_parse_analyse(ParseState *pstate, Query *query,JumbleState *jstate)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fte_post_parse_analyse(ParseState *pstate, Query *query,JumbleState *jstate)
fte_post_parse_analyse(ParseState *pstate, Query *query, JumbleState *jstate)

Comment thread foreign_table_exposer.c
ereport(DEBUG1, (errmsg("Found pg_catalog.pg_class.relkind: [varno:%d, varattno:%d]", varno_index, varattrno_index)));
PgClassRelKindPos *relkindPos = (PgClassRelKindPos*) palloc(sizeof(PgClassRelKindPos));

relkindPos = (PgClassRelKindPos*) palloc(sizeof(PgClassRelKindPos));

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants