Skip to content

Use role-based authentication to push images#43

Merged
harsh-gulhane merged 1 commit into
masterfrom
workflow-assume-role
May 26, 2026
Merged

Use role-based authentication to push images#43
harsh-gulhane merged 1 commit into
masterfrom
workflow-assume-role

Conversation

@sikachu
Copy link
Copy Markdown
Contributor

@sikachu sikachu commented May 26, 2026

This PR updates all workflows in this projects to use role-based authentication instead of access key pair to authenticate with public ECR repository.

We want to move to role-based authentication as it's more secured than using access key pair. The previous access key pair has been revoked.

Because this is a public repository, the PUBLIC_ECR_ROLE and AWS_REGION has been set via repository secrets.

I've confirmed that this is working:

Note that this PR also modernize the way we build and push image by using actions instead of calling docker directly.

@sikachu sikachu requested a review from a team as a code owner May 26, 2026 07:20
@sikachu sikachu requested review from harsh-gulhane and removed request for a team May 26, 2026 07:20
Copy link
Copy Markdown

@harsh-gulhane harsh-gulhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for fixing.

Just noticed that this repo was missed during the self-hosted runner migration; I will raise a separate PR. Not required as it's a public repo.

@harsh-gulhane harsh-gulhane added this pull request to the merge queue May 26, 2026
Merged via the queue into master with commit 2ecae40 May 26, 2026
13 checks passed
@harsh-gulhane harsh-gulhane deleted the workflow-assume-role branch May 26, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants