updated tests and index to handle various invalid inputs

Author: konjoinfinity

dist/index.js

@@ -16,20 +16,24 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", ({ value: true }));
-exports.run = void 0;
+exports.generateRandomCharacters = void 0;
 const core_1 = __nccwpck_require__(186);
-function run() {
+function generateRandomCharacters() {
     return __awaiter(this, void 0, void 0, function* () {
-        const token = (0, core_1.getInput)("GITHUB_TOKEN");
-        const input1 = (0, core_1.getInput)("input1");
-        const input2 = (0, core_1.getInput)("input2");
-        yield (0, core_1.setOutput)("token", token);
-        yield (0, core_1.setOutput)("output1", input1);
-        yield (0, core_1.setOutput)("output2", input2);
+        const numOfCharacters = (0, core_1.getInput)("input1");
+        const startRange = 0x0020;
+        const endRange = 0x007E;
+        const result = [];
+        for (let i = 0; i < Number(numOfCharacters); i++) {
+            const randomCodePoint = Math.floor(Math.random() * (endRange - startRange + 1)) + startRange;
+            const randomCharacter = String.fromCodePoint(randomCodePoint);
+            result.push(randomCharacter);
+        }
+        yield (0, core_1.setOutput)("output1", result.join(''));
     });
 }
-exports.run = run;
-run();
+exports.generateRandomCharacters = generateRandomCharacters;
+generateRandomCharacters();
 
 
 /***/ }),

src/__tests__/index.test.ts

@@ -22,14 +22,49 @@ beforeEach(() => {
 
 test("function returns random chars", async () => {
   // Mock the input values
-  mockedGetInput.mockReturnValueOnce("50");
+  const numOfChars = "100";
+  mockedGetInput.mockReturnValueOnce(numOfChars);
+  mockedGetInput.mockReturnValueOnce("0x0020");
+  mockedGetInput.mockReturnValueOnce("0x007e");
 
   // Run the `run` function
   await generateRandomCharacters();
 
   // Assertions
-  expect(mockedGetInput).toHaveBeenCalledTimes(1);
-  expect(mockedGetInput).toHaveBeenCalledWith("input1");
+  expect(mockedGetInput).toHaveBeenCalledTimes(3);
+  expect(mockedGetInput).toHaveBeenCalledWith("numOfChars");
+  expect(mockedGetInput).toHaveBeenCalledWith("startRange");
+  expect(mockedGetInput).toHaveBeenCalledWith("endRange");
   expect(mockedSetOutput).toHaveBeenCalledTimes(1);
-  expect(mockedSetOutput).toHaveBeenCalledWith("output1", expect.any(String));
+  expect(mockedSetOutput).toHaveBeenCalledWith("output", expect.any(String));
+  const lengthRegex = new RegExp(`^.{${numOfChars}}$`);
+  expect(mockedSetOutput).toHaveBeenCalledWith("output", expect.stringMatching(lengthRegex));
+});
+
+test("should handle numOfChars = 0", async () => {
+  mockedGetInput.mockReturnValueOnce("0");
+  await generateRandomCharacters();
+  expect(mockedSetOutput).toHaveBeenCalledWith("output", "");
+});
+
+it("should handle a negative numOfChars", async () => {
+  mockedGetInput.mockReturnValueOnce("-10");
+  // Expect an error to be thrown, or handle it appropriately in your code.
+  await expect(generateRandomCharacters()).rejects.toThrowError("numOfChars must be a positive integer");
+});
+
+it("should handle invalid hexadecimal values", async () => {
+  mockedGetInput.mockReturnValueOnce("100");
+  mockedGetInput.mockReturnValueOnce("invalidStart");
+  mockedGetInput.mockReturnValueOnce("invalidEnd");
+  // Expect an error to be thrown
+  await expect(generateRandomCharacters()).rejects.toThrowError("Invalid code point NaN");
+});
+
+it("should handle startRange > endRange", async () => {
+  mockedGetInput.mockReturnValueOnce("100");
+  mockedGetInput.mockReturnValueOnce("0x007e"); // End range is smaller
+  mockedGetInput.mockReturnValueOnce("0x0020"); // Start range is greater
+  // Expect an error to be thrown
+  await expect(generateRandomCharacters()).rejects.toThrowError("startRange must be less than or equal to endRange");
 });

src/index.ts

@@ -1,17 +1,27 @@
 import { getInput, setOutput } from "@actions/core";
 
 export async function generateRandomCharacters() {
-  const numOfCharacters = getInput("input1");
-  const startRange = 0x0020;
-  const endRange = 0x007e;
+  const numOfChars = getInput("numOfChars");
+  if (Number(numOfChars) < 0) {
+    throw new TypeError("numOfChars must be a positive integer");
+  }
+  // const startRange = 0x0020;
+  const startRange = getInput("startRange");
+  // const endRange = 0x007e;
+  const endRange = getInput("endRange");
+  if (Number(startRange) > Number(endRange)) {
+    throw new TypeError("startRange must be less than or equal to endRange");
+  }
   const result: string[] = [];
 
-  for (let i = 0; i < Number(numOfCharacters); i++) {
-    const randomCodePoint = Math.floor(Math.random() * (endRange - startRange + 1)) + startRange;
+  for (let i = 0; i < Number(numOfChars); i++) {
+    const randomCodePoint =
+      Math.floor(Math.random() * (Number(endRange) - Number(startRange) + 1)) + Number(startRange);
     const randomCharacter = String.fromCodePoint(randomCodePoint);
     result.push(randomCharacter);
   }
-  await setOutput("output1", result.join(""));
+  console.log(result.join(""));
+  await setOutput("output", result.join(""));
 }
 
 generateRandomCharacters();