Skip to content

Commit df66945

Browse files
fix: resolve rebase conflict in to_proto.rs after TryCastExpr hooks merged
After apache#22550 landed on main, the Literal downcast arm removal conflicted with the TryCastExpr arm that was also removed there. Resolution: drop both the Literal and TryCastExpr downcast arms since both now use try_to_proto hooks.
1 parent 237e503 commit df66945

1 file changed

Lines changed: 0 additions & 21 deletions

File tree

datafusion/proto/src/physical_plan/to_proto.rs

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -343,27 +343,6 @@ pub fn serialize_physical_expr_with_converter(
343343
),
344344
),
345345
})
346-
<<<<<<< HEAD
347-
} else if let Some(lit) = expr.downcast_ref::<Literal>() {
348-
Ok(protobuf::PhysicalExprNode {
349-
expr_id,
350-
expr_type: Some(protobuf::physical_expr_node::ExprType::Literal(
351-
lit.value().try_into()?,
352-
)),
353-
=======
354-
} else if let Some(cast) = expr.downcast_ref::<TryCastExpr>() {
355-
Ok(protobuf::PhysicalExprNode {
356-
expr_id,
357-
expr_type: Some(protobuf::physical_expr_node::ExprType::TryCast(Box::new(
358-
protobuf::PhysicalTryCastNode {
359-
expr: Some(Box::new(
360-
proto_converter.physical_expr_to_proto(cast.expr(), codec)?,
361-
)),
362-
arrow_type: Some(cast.cast_type().try_into()?),
363-
},
364-
))),
365-
>>>>>>> 69352ffb1 (feat(physical-expr): port Literal to try_to_proto / try_from_proto hooks)
366-
})
367346
} else if let Some(expr) = expr.downcast_ref::<ScalarFunctionExpr>() {
368347
let mut buf = Vec::new();
369348
codec.try_encode_udf(expr.fun(), &mut buf)?;

0 commit comments

Comments
 (0)