forked from TanStack/db
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcollection-errors.test.ts
More file actions
473 lines (399 loc) · 14.9 KB
/
collection-errors.test.ts
File metadata and controls
473 lines (399 loc) · 14.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"
import { createCollection } from "../src/collection"
import {
CollectionInErrorStateError,
InvalidCollectionStatusTransitionError,
SyncCleanupError,
} from "../src/errors"
describe(`Collection Error Handling`, () => {
let originalQueueMicrotask: typeof queueMicrotask
let mockQueueMicrotask: ReturnType<typeof vi.fn>
beforeEach(() => {
// Store original queueMicrotask
originalQueueMicrotask = globalThis.queueMicrotask
// Create mock that doesn't actually queue microtasks
mockQueueMicrotask = vi.fn()
globalThis.queueMicrotask = mockQueueMicrotask
})
afterEach(() => {
// Restore original queueMicrotask
globalThis.queueMicrotask = originalQueueMicrotask
vi.clearAllMocks()
})
describe(`Cleanup Error Handling`, () => {
it(`should complete cleanup successfully even when sync cleanup function throws an Error`, async () => {
const collection = createCollection<{ id: string; name: string }>({
id: `error-test-collection`,
getKey: (item) => item.id,
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
// Return a cleanup function that throws an error
return () => {
throw new Error(`Sync cleanup failed`)
}
},
},
})
// Start sync to get the cleanup function
collection.preload()
// Cleanup should complete successfully despite the error
await expect(collection.cleanup()).resolves.toBeUndefined()
// Collection should be in cleaned-up state
expect(collection.status).toBe(`cleaned-up`)
// Verify that a microtask was queued to re-throw the error
expect(mockQueueMicrotask).toHaveBeenCalledTimes(1)
// Get the microtask callback and verify it throws the expected error
const microtaskCallback = mockQueueMicrotask.mock.calls[0]?.[0]
expect(microtaskCallback).toBeDefined()
expect(() => microtaskCallback()).toThrow(SyncCleanupError)
let caughtError: Error | undefined
try {
microtaskCallback()
} catch (error) {
caughtError = error as Error
}
expect(caughtError).toBeInstanceOf(SyncCleanupError)
expect(caughtError?.message).toBe(
`Collection "error-test-collection" sync cleanup function threw an error: Sync cleanup failed`
)
})
it(`should preserve original error stack trace when re-throwing in microtask`, async () => {
const originalError = new Error(`Original sync error`)
const originalStack = `original stack trace`
originalError.stack = originalStack
const collection = createCollection<{ id: string; name: string }>({
id: `stack-trace-test`,
getKey: (item) => item.id,
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
return () => {
throw originalError
}
},
},
})
// Start sync and cleanup
collection.preload()
await collection.cleanup()
// Verify microtask was queued
expect(mockQueueMicrotask).toHaveBeenCalledTimes(1)
// Execute the microtask callback and catch the re-thrown error
const microtaskCallback = mockQueueMicrotask.mock.calls[0]?.[0]
expect(microtaskCallback).toBeDefined()
let caughtError: Error | undefined
try {
microtaskCallback()
} catch (error) {
caughtError = error as Error
}
// Verify the re-thrown error has proper context and preserved stack
expect(caughtError).toBeDefined()
expect(caughtError!.message).toBe(
`Collection "stack-trace-test" sync cleanup function threw an error: Original sync error`
)
expect(caughtError!.stack).toBe(originalStack) // Original stack preserved
expect(caughtError!.cause).toBe(originalError) // Original error chained
})
it(`should handle non-Error thrown values in sync cleanup`, async () => {
const nonErrorValue = `String error message`
const collection = createCollection<{ id: string; name: string }>({
id: `non-error-test`,
getKey: (item) => item.id,
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
return () => {
throw nonErrorValue
}
},
},
})
// Start sync and cleanup
collection.preload()
await collection.cleanup()
// Verify microtask was queued
expect(mockQueueMicrotask).toHaveBeenCalledTimes(1)
// Execute the microtask callback and catch the re-thrown error
const microtaskCallback = mockQueueMicrotask.mock.calls[0]?.[0]
expect(microtaskCallback).toBeDefined()
let caughtError: Error | undefined
try {
microtaskCallback()
} catch (error) {
caughtError = error as Error
}
// Verify non-Error values are handled properly
expect(caughtError).toBeDefined()
expect(caughtError!.message).toBe(
`Collection "non-error-test" sync cleanup function threw an error: String error message`
)
// No cause or stack preservation for non-Error values
expect(caughtError!.cause).toBeUndefined()
})
it(`should not interfere with cleanup when sync cleanup function is undefined`, async () => {
const collection = createCollection<{ id: string; name: string }>({
id: `no-cleanup-test`,
getKey: (item) => item.id,
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
// No cleanup function returned
},
},
})
// Start sync
collection.preload()
// Cleanup should work normally without any cleanup function
await expect(collection.cleanup()).resolves.toBeUndefined()
expect(collection.status).toBe(`cleaned-up`)
// No microtask should be queued when there's no cleanup function
expect(mockQueueMicrotask).not.toHaveBeenCalled()
})
it(`should handle multiple cleanup calls gracefully`, async () => {
const collection = createCollection<{ id: string; name: string }>({
id: `multiple-cleanup-test`,
getKey: (item) => item.id,
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
return () => {
throw new Error(`Cleanup error`)
}
},
},
})
// Start sync
collection.preload()
// First cleanup should complete successfully despite error
await expect(collection.cleanup()).resolves.toBeUndefined()
expect(collection.status).toBe(`cleaned-up`)
// Second cleanup should also complete successfully (idempotent)
await expect(collection.cleanup()).resolves.toBeUndefined()
expect(collection.status).toBe(`cleaned-up`)
// Third cleanup should also work (proving idempotency)
await expect(collection.cleanup()).resolves.toBeUndefined()
expect(collection.status).toBe(`cleaned-up`)
// Verify that microtasks were queued for cleanup attempts
// (Each cleanup call that encounters a cleanup function will queue a microtask)
expect(mockQueueMicrotask).toHaveBeenCalled()
// All queued microtasks should throw the expected error when executed
for (const call of mockQueueMicrotask.mock.calls) {
const microtaskCallback = call[0]
expect(microtaskCallback).toBeDefined()
expect(() => microtaskCallback()).toThrow(SyncCleanupError)
let caughtError: Error | undefined
try {
microtaskCallback()
} catch (error) {
caughtError = error as Error
}
expect(caughtError).toBeInstanceOf(SyncCleanupError)
expect(caughtError?.message).toBe(
`Collection "multiple-cleanup-test" sync cleanup function threw an error: Cleanup error`
)
}
})
})
describe(`Operation Validation Errors`, () => {
it(`should throw helpful errors when trying to use operations on error status collection`, async () => {
const collection = createCollection<{ id: string; name: string }>({
id: `error-status-test`,
getKey: (item) => item.id,
sync: {
sync: () => {
throw new Error(`Sync initialization failed`)
},
},
})
// Try to start sync, which should put collection in error state
try {
await collection.preload()
} catch {
// Expected to throw
}
expect(collection.status).toBe(`error`)
// Now operations should be blocked with helpful messages
expect(() => {
collection.insert({ id: `1`, name: `test` })
}).toThrow(CollectionInErrorStateError)
expect(() => {
collection.update(`1`, (draft) => {
draft.name = `updated`
})
}).toThrow(CollectionInErrorStateError)
expect(() => {
collection.delete(`1`)
}).toThrow(CollectionInErrorStateError)
})
it(`should automatically restart collection when operations are called on cleaned-up collection`, async () => {
const collection = createCollection<{ id: string; name: string }>({
id: `cleaned-up-test`,
getKey: (item) => item.id,
onInsert: async () => {}, // Add handler to prevent "no handler" error
onUpdate: async () => {}, // Add handler to prevent "no handler" error
onDelete: async () => {}, // Add handler to prevent "no handler" error
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
},
},
})
// Clean up the collection
await collection.cleanup()
expect(collection.status).toBe(`cleaned-up`)
// Insert operation should automatically restart the collection
expect(() => {
collection.insert({ id: `1`, name: `test` })
}).not.toThrow()
// Collection should no longer be in cleaned-up state
expect(collection.status).not.toBe(`cleaned-up`)
// Test with a new collection for update - need to start with data
const collectionWithData = createCollection<{ id: string; name: string }>(
{
id: `cleaned-up-test-2`,
getKey: (item) => item.id,
onUpdate: async () => {},
onDelete: async () => {},
sync: {
sync: ({ begin, write, commit }) => {
begin()
write({ type: `insert`, value: { id: `2`, name: `test2` } })
commit()
},
},
}
)
// Wait for initial sync and then cleanup
await collectionWithData.preload()
await collectionWithData.cleanup()
expect(collectionWithData.status).toBe(`cleaned-up`)
// Update should restart the collection
expect(() => {
collectionWithData.update(`2`, (draft) => {
draft.name = `updated`
})
}).not.toThrow()
expect(collectionWithData.status).not.toBe(`cleaned-up`)
// Reset and test delete
await collectionWithData.cleanup()
expect(collectionWithData.status).toBe(`cleaned-up`)
expect(() => {
collectionWithData.delete(`2`)
}).not.toThrow()
expect(collectionWithData.status).not.toBe(`cleaned-up`)
})
})
describe(`State Transition Validation`, () => {
it(`should prevent invalid state transitions`, () => {
const collection = createCollection<{ id: string; name: string }>({
id: `transition-test`,
getKey: (item) => item.id,
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
},
},
})
// Access private method for testing (using any cast)
const collectionImpl = collection as any
expect(collection.status).toBe(`idle`)
// Test invalid transition
expect(() => {
collectionImpl.validateStatusTransition(`ready`, `loading`)
}).toThrow(InvalidCollectionStatusTransitionError)
// Test valid transition
expect(() => {
collectionImpl.validateStatusTransition(`idle`, `loading`)
}).not.toThrow()
})
it(`should allow all valid state transitions`, () => {
const collection = createCollection<{ id: string; name: string }>({
id: `valid-transitions-test`,
getKey: (item) => item.id,
sync: {
sync: ({ begin, commit }) => {
begin()
commit()
},
},
})
const collectionImpl = collection as any
// Valid transitions from idle
expect(() =>
collectionImpl.validateStatusTransition(`idle`, `loading`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`idle`, `error`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`idle`, `cleaned-up`)
).not.toThrow()
// Valid transitions from loading
expect(() =>
collectionImpl.validateStatusTransition(`loading`, `initialCommit`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`loading`, `error`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`loading`, `cleaned-up`)
).not.toThrow()
// Valid transitions from initialCommit
expect(() =>
collectionImpl.validateStatusTransition(`initialCommit`, `ready`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`initialCommit`, `error`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`initialCommit`, `cleaned-up`)
).not.toThrow()
// Valid transitions from ready
expect(() =>
collectionImpl.validateStatusTransition(`ready`, `cleaned-up`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`ready`, `error`)
).not.toThrow()
// Valid transitions from error (allow recovery)
expect(() =>
collectionImpl.validateStatusTransition(`error`, `cleaned-up`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`error`, `idle`)
).not.toThrow()
// Valid transitions from cleaned-up (allow restart)
expect(() =>
collectionImpl.validateStatusTransition(`cleaned-up`, `loading`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`cleaned-up`, `error`)
).not.toThrow()
// Allow same-state transitions (idempotent operations)
expect(() =>
collectionImpl.validateStatusTransition(`idle`, `idle`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(
`initialCommit`,
`initialCommit`
)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`ready`, `ready`)
).not.toThrow()
expect(() =>
collectionImpl.validateStatusTransition(`cleaned-up`, `cleaned-up`)
).not.toThrow()
})
})
})