refactor: replace CString with pyo3::ffi::c_str! for FFI table provider names

Author: kosiew

docs/source/contributor-guide/ffi.rst

@@ -161,8 +161,8 @@ for our provider thusly:
 
 .. code-block:: rust
 
-    let name = CString::new("datafusion_table_provider")?;
-    let my_capsule = PyCapsule::new_bound(py, provider, Some(name))?;
+    let name = pyo3::ffi::c_str!("datafusion_table_provider");
+    let my_capsule = PyCapsule::new_bound(py, provider, Some(name.to_owned()))?;
 
 On the receiving side, turn this pycapsule object into the ``FFI_TableProvider``, which
 can then be turned into a ``ForeignTableProvider`` the associated code is:

docs/source/user-guide/io/table_provider.rst

@@ -37,13 +37,13 @@ A complete example can be found in the `examples folder <https://github.com/apac
             &self,
             py: Python<'py>,
         ) -> PyResult<Bound<'py, PyCapsule>> {
-            let name = CString::new("datafusion_table_provider").unwrap();
+            let name = pyo3::ffi::c_str!("datafusion_table_provider");
 
             let provider = Arc::new(self.clone())
                 .map_err(|e| PyRuntimeError::new_err(e.to_string()))?;
             let provider = FFI_TableProvider::new(Arc::new(provider), false);
 
-            PyCapsule::new_bound(py, provider, Some(name.clone()))
+            PyCapsule::new_bound(py, provider, Some(name.to_owned()))
         }
     }
 

src/dataframe.rs

@@ -16,7 +16,6 @@
 // under the License.
 
 use std::collections::HashMap;
-use std::ffi::CString;
 use std::sync::Arc;
 use tokio::sync::Mutex;
 
@@ -85,12 +84,12 @@ impl PyTableProvider {
         &self,
         py: Python<'py>,
     ) -> PyResult<Bound<'py, PyCapsule>> {
-        let name = CString::new("datafusion_table_provider").unwrap();
+        let name = pyo3::ffi::c_str!("datafusion_table_provider");
 
         let runtime = get_tokio_runtime().0.handle().clone();
         let provider = FFI_TableProvider::new(Arc::clone(&self.provider), false, Some(runtime));
 
-        PyCapsule::new(py, provider, Some(name.clone()))
+        PyCapsule::new(py, provider, Some(name.to_owned()))
     }
 }
 
@@ -994,9 +993,10 @@ impl PyDataFrame {
         let reader: Box<dyn RecordBatchReader + Send> = Box::new(reader);
 
         let stream = FFI_ArrowArrayStream::new(reader);
-        let name = CString::new("arrow_array_stream").unwrap();
+        let name = pyo3::ffi::c_str!("arrow_array_stream");
 
-        let capsule = PyCapsule::new(py, stream, Some(name)).map_err(py_datafusion_err)?;
+        let capsule =
+            PyCapsule::new(py, stream, Some(name.to_owned())).map_err(py_datafusion_err)?;
         Ok(capsule)
     }