refactor: Remove max_cell_length from DataframeDisplayConfig and related tests

Author: kosiew

python/datafusion/context.py

@@ -89,7 +89,6 @@ def __init__(
         self,
         max_table_bytes: Optional[int] = None,
         min_table_rows: Optional[int] = None,
-        max_cell_length: Optional[int] = None,
         max_table_rows_in_repr: Optional[int] = None,
     ) -> None:
         """Create a new :py:class:`DataframeDisplayConfig` instance.
@@ -99,8 +98,6 @@ def __init__(
                 (default: 2MB)
             min_table_rows: Minimum number of table rows to display
                 (default: 20)
-            max_cell_length: Maximum length of a cell before it gets minimized
-                (default: 25)
             max_table_rows_in_repr: Maximum number of rows to display in repr
                 string output (default: 10)
         """
@@ -109,14 +106,11 @@ def __init__(
             self._validate_positive(max_table_bytes, "max_table_bytes")
         if min_table_rows is not None:
             self._validate_positive(min_table_rows, "min_table_rows")
-        if max_cell_length is not None:
-            self._validate_positive(max_cell_length, "max_cell_length")
         if max_table_rows_in_repr is not None:
             self._validate_positive(max_table_rows_in_repr, "max_table_rows_in_repr")
         self.config_internal = DataframeDisplayConfigInternal(
             max_table_bytes=max_table_bytes,
             min_table_rows=min_table_rows,
-            max_cell_length=max_cell_length,
             max_table_rows_in_repr=max_table_rows_in_repr,
         )
 
@@ -155,16 +149,6 @@ def min_table_rows(self, value: int) -> None:
         self._validate_positive(value, "min_table_rows")
         self.config_internal.min_table_rows = value
 
-    @property
-    def max_cell_length(self) -> int:
-        """Get the maximum length of a cell before it gets minimized."""
-        return self.config_internal.max_cell_length
-
-    @max_cell_length.setter
-    def max_cell_length(self, value: int) -> None:
-        """Set the maximum length of a cell before it gets minimized."""
-        self._validate_positive(value, "max_cell_length")
-        self.config_internal.max_cell_length = value
 
     @property
     def max_table_rows_in_repr(self) -> int:
@@ -612,7 +596,6 @@ def with_display_config(
         self,
         max_table_bytes: Optional[int] = None,
         min_table_rows: Optional[int] = None,
-        max_cell_length: Optional[int] = None,
         max_table_rows_in_repr: Optional[int] = None,
     ) -> SessionContext:
         """Configure the display options for DataFrames.
@@ -622,8 +605,6 @@ def with_display_config(
                 (default: 2MB)
             min_table_rows: Minimum number of table rows to display
                 (default: 20)
-            max_cell_length: Maximum length of a cell before it gets minimized
-                (default: 25)
             max_table_rows_in_repr: Maximum number of rows to display in repr
                 string output (default: 10)
 
@@ -633,7 +614,6 @@ def with_display_config(
         display_config = DataframeDisplayConfig(
             max_table_bytes=max_table_bytes,
             min_table_rows=min_table_rows,
-            max_cell_length=max_cell_length,
             max_table_rows_in_repr=max_table_rows_in_repr,
         )
 

python/tests/test_dataframe.py

@@ -71,24 +71,20 @@ def test_display_config():
     config = DataframeDisplayConfig(
         max_table_bytes=1024,
         min_table_rows=10,
-        max_cell_length=15,
         max_table_rows_in_repr=5,
     )
 
     assert config.max_table_bytes == 1024
     assert config.min_table_rows == 10
-    assert config.max_cell_length == 15
     assert config.max_table_rows_in_repr == 5
 
     # Test property setters
     config.max_table_bytes = 2048
     config.min_table_rows = 20
-    config.max_cell_length = 30
     config.max_table_rows_in_repr = 10
 
     assert config.max_table_bytes == 2048
     assert config.min_table_rows == 20
-    assert config.max_cell_length == 30
     assert config.max_table_rows_in_repr == 10
 
     # Test property setter validation
@@ -98,9 +94,6 @@ def test_display_config():
     with pytest.raises(ValueError, match="min_table_rows must be greater than 0"):
         config.min_table_rows = -1
 
-    with pytest.raises(ValueError, match="max_cell_length must be greater than 0"):
-        config.max_cell_length = 0
-
     with pytest.raises(
         ValueError, match="max_table_rows_in_repr must be greater than 0"
     ):
@@ -140,7 +133,6 @@ def test_display_config_in_init(data, clean_formatter_state):
     display_config = DataframeDisplayConfig(
         max_table_bytes=1024,
         min_table_rows=5,
-        max_cell_length=10,
         max_table_rows_in_repr=3,
     )
 
@@ -152,7 +144,6 @@ def test_display_config_in_init(data, clean_formatter_state):
     ctx2 = ctx.with_display_config(
         max_table_bytes=1024,
         min_table_rows=5,
-        max_cell_length=10,
         max_table_rows_in_repr=3,
     )
     df2 = ctx2.from_pylist(data)