Improve error message in DataFrame sorting to provide clearer guidance on expression construction

kosiew · kosiew · commit b6a02048d602 · 2025-09-01T16:50:56.000+08:00
diff --git a/python/datafusion/dataframe.py b/python/datafusion/dataframe.py
@@ -563,7 +563,7 @@ def sort(self, *exprs: Expr | SortExpr | str) -> DataFrame:
             else:
                 error = (
                     "Expected Expr or column name, found:"
-                    f" {type(e).__name__}. Use col() or lit() to construct expressions."
+                    f" {type(e).__name__}. {_EXPR_TYPE_ERROR}."
                 )
                 raise TypeError(error)
         return DataFrame(self.df.sort(*exprs_raw))

Original file line number	Diff line number	Diff line change
`@@ -563,7 +563,7 @@ def sort(self, *exprs: Expr \| SortExpr \| str) -> DataFrame:`
`563`	`563`	`else:`
`564`	`564`	`error = (`
`565`	`565`	`"Expected Expr or column name, found:"`
`566`		`- f" {type(e).__name__}. Use col() or lit() to construct expressions."`
	`566`	`+ f" {type(e).__name__}. {_EXPR_TYPE_ERROR}."`
`567`	`567`	`)`
`568`	`568`	`raise TypeError(error)`
`569`	`569`	`return DataFrame(self.df.sort(*exprs_raw))`