refactor(cli): log success on create/update service-account

Match the majority of create commands (environment, flow, policy): instead
of printing the response with --output table/json, create and update
service-account now log a one-line success message. get and list keep
--output (universal for those verbs), and delete already logs a message.
The api-key commands keep --output where it makes sense (create api-key
returns a secret to capture).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SWQ362qtJBoP3ncxRck9qu

Author: claude

cmd/kosli/createServiceAccount.go

@@ -5,7 +5,6 @@ import (
 	"net/http"
 	"net/url"
 
-	"github.com/kosli-dev/cli/internal/output"
 	"github.com/kosli-dev/cli/internal/requests"
 	"github.com/spf13/cobra"
 )
@@ -27,7 +26,6 @@ kosli create service-account yourServiceAccountName \
 `
 
 type createServiceAccountOptions struct {
-	output  string
 	payload createServiceAccountPayload
 }
 
@@ -53,13 +51,12 @@ func newCreateServiceAccountCmd(out io.Writer) *cobra.Command {
 			return nil
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return o.run(out, args)
+			return o.run(args)
 		},
 	}
 
 	cmd.Flags().StringVarP(&o.payload.Description, "description", "d", "", serviceAccountDescriptionFlag)
 	cmd.Flags().StringVar(&o.payload.Privilege, "privilege", "", serviceAccountPrivilegeFlag)
-	cmd.Flags().StringVarP(&o.output, "output", "o", "table", outputFlag)
 	addDryRunFlag(cmd)
 
 	err := RequireFlags(cmd, []string{"privilege"})
@@ -70,7 +67,7 @@ func newCreateServiceAccountCmd(out io.Writer) *cobra.Command {
 	return cmd
 }
 
-func (o *createServiceAccountOptions) run(out io.Writer, args []string) error {
+func (o *createServiceAccountOptions) run(args []string) error {
 	o.payload.Name = args[0]
 	url, err := url.JoinPath(global.Host, "api/v2/service-accounts", global.Org)
 	if err != nil {
@@ -84,14 +81,9 @@ func (o *createServiceAccountOptions) run(out io.Writer, args []string) error {
 		DryRun:  global.DryRun,
 		Token:   global.ApiToken,
 	}
-	response, err := kosliClient.Do(reqParams)
-	if err != nil || global.DryRun {
-		return err
+	_, err = kosliClient.Do(reqParams)
+	if err == nil && !global.DryRun {
+		logger.Info("service account %s was created", o.payload.Name)
 	}
-
-	return output.FormattedPrint(response.Body, o.output, out, 0,
-		map[string]output.FormatOutputFunc{
-			"table": printServiceAccountAsTable,
-			"json":  output.PrintJson,
-		})
+	return err
 }

cmd/kosli/serviceAccount_test.go

@@ -214,9 +214,9 @@ func (suite *ServiceAccountCommandTestSuite) TestServiceAccountSuccessOutput() {
 	tests := []cmdTestCase{
 		{
 			wantError:   false,
-			name:        "create prints the created service account",
-			cmd:         "create service-account ci-bot --privilege member --output json" + args,
-			goldenRegex: `ci-bot`,
+			name:        "create reports the created service account",
+			cmd:         "create service-account ci-bot --privilege member" + args,
+			goldenRegex: `service account ci-bot was created`,
 		},
 		{
 			wantError:   false,
@@ -232,9 +232,9 @@ func (suite *ServiceAccountCommandTestSuite) TestServiceAccountSuccessOutput() {
 		},
 		{
 			wantError:   false,
-			name:        "update prints the updated service account",
-			cmd:         "update service-account ci-bot --privilege admin --output json" + args,
-			goldenRegex: `updated description`,
+			name:        "update reports the updated service account",
+			cmd:         "update service-account ci-bot --privilege admin" + args,
+			goldenRegex: `service account ci-bot was updated`,
 		},
 	}
 

cmd/kosli/updateServiceAccount.go

@@ -5,7 +5,6 @@ import (
 	"net/http"
 	"net/url"
 
-	"github.com/kosli-dev/cli/internal/output"
 	"github.com/kosli-dev/cli/internal/requests"
 	"github.com/spf13/cobra"
 )
@@ -33,7 +32,6 @@ kosli update service-account yourServiceAccountName \
 type updateServiceAccountOptions struct {
 	description string
 	privilege   string
-	output      string
 }
 
 func newUpdateServiceAccountCmd(out io.Writer) *cobra.Command {
@@ -52,19 +50,18 @@ func newUpdateServiceAccountCmd(out io.Writer) *cobra.Command {
 			return RequireAtLeastOneOfFlags(cmd, []string{"description", "privilege"})
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
-			return o.run(out, cmd, args)
+			return o.run(cmd, args)
 		},
 	}
 
 	cmd.Flags().StringVarP(&o.description, "description", "d", "", serviceAccountDescriptionFlag)
 	cmd.Flags().StringVar(&o.privilege, "privilege", "", serviceAccountPrivilegeFlag)
-	cmd.Flags().StringVarP(&o.output, "output", "o", "table", outputFlag)
 	addDryRunFlag(cmd)
 
 	return cmd
 }
 
-func (o *updateServiceAccountOptions) run(out io.Writer, cmd *cobra.Command, args []string) error {
+func (o *updateServiceAccountOptions) run(cmd *cobra.Command, args []string) error {
 	url, err := url.JoinPath(global.Host, "api/v2/service-accounts", global.Org, args[0])
 	if err != nil {
 		return err
@@ -88,14 +85,9 @@ func (o *updateServiceAccountOptions) run(out io.Writer, cmd *cobra.Command, arg
 		DryRun:  global.DryRun,
 		Token:   global.ApiToken,
 	}
-	response, err := kosliClient.Do(reqParams)
-	if err != nil || global.DryRun {
-		return err
+	_, err = kosliClient.Do(reqParams)
+	if err == nil && !global.DryRun {
+		logger.Info("service account %s was updated", args[0])
 	}
-
-	return output.FormattedPrint(response.Body, o.output, out, 0,
-		map[string]output.FormatOutputFunc{
-			"table": printServiceAccountAsTable,
-			"json":  output.PrintJson,
-		})
+	return err
 }