Commit 64781a6
fix(cloudrun): use errors.Join in Close() so both errors propagate (#4986)
Previous Close() returned only the first error if both client closes
failed — the second was silently dropped:
if sErr != nil {
return sErr
}
return rErr
errors.Join (Go 1.20+) preserves both, simpler, no behavior change
when only one fails. Low-impact for a short-lived CLI but cheap
to do right.
Addresses two duplicate review comments on PR 833.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 41808e6 commit 64781a6
1 file changed
Lines changed: 4 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
67 | | - | |
68 | | - | |
| 68 | + | |
| 69 | + | |
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 75 | + | |
80 | 76 | | |
81 | 77 | | |
82 | 78 | | |
| |||
0 commit comments