apply copilot reviews (#689)

Author: sami-alajrami

cmd/kosli/snapshotK8S.go

@@ -161,15 +161,18 @@ func newSnapshotK8SCmd(out io.Writer) *cobra.Command {
 		Example: snapshotK8SExample,
 		Args: func(cmd *cobra.Command, args []string) error {
 			configFileFlag := cmd.Flags().Lookup("config-file")
-			hasConfigFile := configFileFlag != nil && configFileFlag.Changed
-			if hasConfigFile && len(args) > 0 {
+			if configFileFlag != nil && configFileFlag.Changed && o.configFilePath == "" {
+				return fmt.Errorf("cannot use '--config-file' with an empty value")
+			}
+			useConfigFile := o.configFilePath != ""
+			if useConfigFile && len(args) > 0 {
 				return fmt.Errorf("cannot use '--config-file' together with a positional environment name argument")
 			}
-			if !hasConfigFile && len(args) == 0 {
+			if !useConfigFile && len(args) == 0 {
 				return fmt.Errorf("requires either a positional environment name argument or --config-file")
 			}
-			if !hasConfigFile && len(args) > 1 {
-				return fmt.Errorf("accepts at most 1 arg(s), received %d", len(args))
+			if !useConfigFile && len(args) > 1 {
+				return fmt.Errorf("accepts 1 arg(s), received %d", len(args))
 			}
 			return nil
 		},
@@ -180,8 +183,11 @@ func newSnapshotK8SCmd(out io.Writer) *cobra.Command {
 			}
 
 			configFileFlag := cmd.Flags().Lookup("config-file")
-			hasConfigFile := configFileFlag != nil && configFileFlag.Changed
-			if hasConfigFile {
+			if configFileFlag != nil && configFileFlag.Changed && o.configFilePath == "" {
+				return ErrorBeforePrintingUsage(cmd, "cannot use '--config-file' with an empty value")
+			}
+			useConfigFile := o.configFilePath != ""
+			if useConfigFile {
 				namespaceFlagNames := []string{"namespaces", "exclude-namespaces", "namespaces-regex", "exclude-namespaces-regex"}
 				for _, flagName := range namespaceFlagNames {
 					if f := cmd.Flags().Lookup(flagName); f != nil && f.Changed {
@@ -191,7 +197,20 @@ func newSnapshotK8SCmd(out io.Writer) *cobra.Command {
 				return nil
 			}
 
-			return MuXRequiredFlags(cmd, []string{"namespaces", "exclude-namespaces"}, false)
+			// Include vs exclude namespace flags mutual exclusion (all combinations)
+			if err := MuXRequiredFlags(cmd, []string{"namespaces", "exclude-namespaces"}, false); err != nil {
+				return err
+			}
+			if err := MuXRequiredFlags(cmd, []string{"namespaces", "exclude-namespaces-regex"}, false); err != nil {
+				return err
+			}
+			if err := MuXRequiredFlags(cmd, []string{"namespaces-regex", "exclude-namespaces"}, false); err != nil {
+				return err
+			}
+			if err := MuXRequiredFlags(cmd, []string{"namespaces-regex", "exclude-namespaces-regex"}, false); err != nil {
+				return err
+			}
+			return nil
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
 			clientset, err := kube.NewK8sClientSet(o.kubeconfig)

cmd/kosli/snapshotK8S_test.go

@@ -38,12 +38,30 @@ func (suite *SnapshotK8STestSuite) TestSnapshotK8SCmd() {
 			cmd:       fmt.Sprintf(`snapshot k8s %s --namespaces default --exclude-namespaces default %s`, suite.envName, suite.defaultKosliArguments),
 			golden:    "Error: only one of --namespaces, --exclude-namespaces is allowed\n",
 		},
+		{
+			wantError: true,
+			name:      "snapshot K8S fails if both --namespaces-regex and --exclude-namespaces are set",
+			cmd:       fmt.Sprintf(`snapshot k8s %s --namespaces-regex "^default" --exclude-namespaces kube-system %s`, suite.envName, suite.defaultKosliArguments),
+			golden:    "Error: only one of --namespaces-regex, --exclude-namespaces is allowed\n",
+		},
+		{
+			wantError: true,
+			name:      "snapshot K8S fails if both --namespaces and --exclude-namespaces-regex are set",
+			cmd:       fmt.Sprintf(`snapshot k8s %s --namespaces default --exclude-namespaces-regex "^kube-" %s`, suite.envName, suite.defaultKosliArguments),
+			golden:    "Error: only one of --namespaces, --exclude-namespaces-regex is allowed\n",
+		},
 		{
 			wantError: true,
 			name:      "snapshot K8S fails if no args and no --config-file",
 			cmd:       fmt.Sprintf(`snapshot k8s %s`, suite.defaultKosliArguments),
 			golden:    "Error: requires either a positional environment name argument or --config-file\n",
 		},
+		{
+			wantError: true,
+			name:      "snapshot K8S fails if --config-file is set to empty value",
+			cmd:       fmt.Sprintf(`snapshot k8s --config-file "" %s`, suite.defaultKosliArguments),
+			golden:    "Error: cannot use '--config-file' with an empty value\n",
+		},
 		{
 			wantError: true,
 			name:      "snapshot K8S fails if --config-file and positional arg are both provided",