Remove ~ from authorized characters in environment name (#539)

Author: lbmilje

cmd/kosli/createEnvironment_test.go

@@ -100,7 +100,7 @@ func (suite *CreateEnvironmentCommandTestSuite) TestCreateEnvironmentCmd() {
 			wantError: true,
 			name:      "fails when name is considered invalid by the server",
 			cmd:       "create env 'foo bar' --type K8S" + suite.defaultKosliArguments,
-			golden:    "Error: Input payload validation failed: map[name:'foo bar' does not match '^[a-zA-Z0-9][a-zA-Z0-9\\\\.\\\\-_~]*$']\n",
+			golden:    "Error: Input payload validation failed: map[name:'foo bar' does not match '^[a-zA-Z0-9][a-zA-Z0-9\\\\.\\\\-_]*$']\n",
 		},
 		{
 			wantError: false,

cmd/kosli/multiHost.go

@@ -59,7 +59,7 @@ func runMultiHost(args []string) (string, error) {
 		errorMessage += err0.Error()
 	}
 
-	for i:=1; i < len(opts.hosts); i++ {
+	for i := 1; i < len(opts.hosts); i++ {
 		argsN := argsAppendHostApiTokenFlags(i)
 		outputN, errN := runBufferedInnerMain(argsN)
 
@@ -75,7 +75,7 @@ func runMultiHost(args []string) (string, error) {
 			errorMessage += fmt.Sprintf("\n%s", errN.Error())
 		}
 	}
-	
+
 	var err error
 	if errorMessage != "" {
 		err = errors.New(errorMessage)

cmd/kosli/multiHost_test.go

@@ -121,7 +121,6 @@ func (suite *MultiHostTestSuite) TestRunDoubledHost() {
 			stdOut: []string{"OK", ""},
 			err:    error(nil),
 		},
-		
 	} {
 		defer func(original []string) { os.Args = original }(os.Args)
 		os.Args = t.args
@@ -157,7 +156,6 @@ func (suite *MultiHostTestSuite) TestRunTripledHost() {
 			stdOut: []string{"OK", ""},
 			err:    error(nil),
 		},
-		
 	} {
 		defer func(original []string) { os.Args = original }(os.Args)
 		os.Args = t.args
@@ -261,21 +259,21 @@ func charAt(s string, n int) string {
 	return fmt.Sprintf("%v", c)
 }
 
-		// {
-		// 	name:   "in debug mode also returns secondary call output",
-		// 	args:   doubledArgs([]string{"kosli", "status", "--debug"}),
-		// 	stdOut: StatusDebugLines(),
-		// 	err:    error(nil),
-		// },
-		// {
-		// 	name:   "--help prints output once",
-		// 	args:   doubledArgs([]string{"kosli", "status", "--help"}),
-		// 	stdOut: HelpStatusLines(),
-		// 	err:    error(nil),
-		// },
-		// {
-		// 	name:   "bad-flag never gets to call runMultiHost() because isMultiHost() returns false",
-		// 	args:   doubledArgs([]string{"kosli", "status", "--bad-flag"}),
-		// 	stdOut: BadFlagLines(),
-		// 	err:    error(nil),
-		// },
+// {
+// 	name:   "in debug mode also returns secondary call output",
+// 	args:   doubledArgs([]string{"kosli", "status", "--debug"}),
+// 	stdOut: StatusDebugLines(),
+// 	err:    error(nil),
+// },
+// {
+// 	name:   "--help prints output once",
+// 	args:   doubledArgs([]string{"kosli", "status", "--help"}),
+// 	stdOut: HelpStatusLines(),
+// 	err:    error(nil),
+// },
+// {
+// 	name:   "bad-flag never gets to call runMultiHost() because isMultiHost() returns false",
+// 	args:   doubledArgs([]string{"kosli", "status", "--bad-flag"}),
+// 	stdOut: BadFlagLines(),
+// 	err:    error(nil),
+// },

cmd/kosli/renameEnvironment_test.go

@@ -39,7 +39,7 @@ func (suite *RenameEnvironmentCommandTestSuite) TestRenameEnvironmentCmd() {
 			wantError: true,
 			name:      "renaming environment fails if the new name is illegal",
 			cmd:       fmt.Sprintf(`rename environment %s 'new illegal name' %s`, suite.envName, suite.defaultKosliArguments),
-			golden:    "Error: 'new illegal name' is an invalid name for environments. Valid names should start with an alphanumeric and only contain alphanumeric characters, '.', '-', '_' and '~'.\n",
+			golden:    "Error: 'new illegal name' is an invalid name for environments. Valid names should start with an alphanumeric and only contain alphanumeric characters, '.', '-' and '_'.\n",
 		},
 		{
 			wantError: true,