Commit beda1fd
Makefile: fixed setup_test_to_use_xxx to only clean up the cli containers and not all containers (#837)
* fix(make): scope setup_test_to_use_local_image cleanup to the compose stack
The previous target ran `docker ps -aq | xargs -r docker rm -fv`,
which force-removes EVERY container on the host — not just the kosli
test stack defined in docker-compose.yml. That's a footgun for anyone
running unrelated containers (other projects, dev DBs, sidecar tools)
on the same machine.
`docker compose down -v` only touches the project's own containers
plus its named volumes — exactly what's needed when switching to a
locally-built server image. Same approach already used by
bin/reset-or-start-server.sh.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(make): scope setup_test_to_use_staging_server_image cleanup to the compose stack
Same broad-cleanup footgun as setup_test_to_use_local_image fixed in
the previous commit — `docker ps -aq | xargs -r docker rm -fv` force-
removes EVERY container on the host. Replaced with `docker compose
down -v`, which only touches the project's own compose stack.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 346ca39 commit beda1fd
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | 117 | | |
118 | | - | |
| 118 | + | |
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| |||
0 commit comments