fix: exit code dispatch was dead code — logger.Error called Fatalf before ExitCodeFor

Three bugs found by five-agent swarm review:

1. main.go: logger.Error() calls log.Fatalf() which exits 1 immediately,
   making os.Exit(ExitCodeFor(err)) unreachable dead code. Replaced with
   fmt.Fprintf to stderr so the differentiated exit code actually takes
   effect. Same fix in innerMain for the unknown-subcommand path.

2. requests.go: HTTP 5xx responses were returned as plain fmt.Errorf,
   falling through to exit 1. Now wrapped as ErrServer (exit 2).

3. docs.go/testHelpers/etc: import ordering and alignment (gofmt).

Author: dangrondahl

cmd/kosli/assertPRAzure.go

@@ -4,8 +4,8 @@ import (
 	"fmt"
 	"io"
 
-	kosliErrors "github.com/kosli-dev/cli/internal/errors"
 	azUtils "github.com/kosli-dev/cli/internal/azure"
+	kosliErrors "github.com/kosli-dev/cli/internal/errors"
 	"github.com/spf13/cobra"
 )
 

cmd/kosli/assertPRBitbucket.go

@@ -4,8 +4,8 @@ import (
 	"fmt"
 	"io"
 
-	kosliErrors "github.com/kosli-dev/cli/internal/errors"
 	bbUtils "github.com/kosli-dev/cli/internal/bitbucket"
+	kosliErrors "github.com/kosli-dev/cli/internal/errors"
 	"github.com/spf13/cobra"
 )
 

cmd/kosli/docs.go

@@ -67,27 +67,27 @@ var (
 // Commands not in this map receive exitCodesDefault.
 var commandExitCodes = map[string][]docgen.ExitCodeEntry{
 	// assert commands — can signal compliance violations
-	"kosli assert artifact":             exitCodesAssert,
-	"kosli assert approval":             exitCodesAssert,
-	"kosli assert snapshot":             exitCodesAssert,
-	"kosli assert pullrequest github":   exitCodesAssert,
-	"kosli assert pullrequest gitlab":   exitCodesAssert,
-	"kosli assert pullrequest azure":    exitCodesAssert,
+	"kosli assert artifact":              exitCodesAssert,
+	"kosli assert approval":              exitCodesAssert,
+	"kosli assert snapshot":              exitCodesAssert,
+	"kosli assert pullrequest github":    exitCodesAssert,
+	"kosli assert pullrequest gitlab":    exitCodesAssert,
+	"kosli assert pullrequest azure":     exitCodesAssert,
 	"kosli assert pullrequest bitbucket": exitCodesAssert,
-	"kosli assert status":               exitCodesAssertStatus,
+	"kosli assert status":                exitCodesAssertStatus,
 	// attest commands with --assert flag — can signal compliance violations when --assert is used
 	"kosli attest pullrequest github":    exitCodesAttest,
 	"kosli attest pullrequest gitlab":    exitCodesAttest,
 	"kosli attest pullrequest azure":     exitCodesAttest,
 	"kosli attest pullrequest bitbucket": exitCodesAttest,
 	"kosli attest jira":                  exitCodesAttest,
 	// evaluate commands — policy denial exits with code 1
-	"kosli evaluate trail":              exitCodesEvaluate,
-	"kosli evaluate trails":             exitCodesEvaluate,
+	"kosli evaluate trail":  exitCodesEvaluate,
+	"kosli evaluate trails": exitCodesEvaluate,
 	// non-API commands
-	"kosli version":                     exitCodesNoAPI,
-	"kosli completion":                  exitCodesNoAPI,
-	"kosli docs":                        exitCodesNoAPI,
+	"kosli version":    exitCodesNoAPI,
+	"kosli completion": exitCodesNoAPI,
+	"kosli docs":       exitCodesNoAPI,
 }
 
 const docsShortDesc = `Generate documentation files for Kosli CLI. `

cmd/kosli/evaluateHelpers.go

@@ -8,8 +8,8 @@ import (
 	"net/url"
 	"os"
 
-	"github.com/kosli-dev/cli/internal/evaluate"
 	kosliErrors "github.com/kosli-dev/cli/internal/errors"
+	"github.com/kosli-dev/cli/internal/evaluate"
 	"github.com/kosli-dev/cli/internal/output"
 	"github.com/kosli-dev/cli/internal/requests"
 	"github.com/spf13/cobra"

cmd/kosli/main.go

@@ -37,7 +37,7 @@ func main() {
 		}
 	}
 	if err != nil {
-		logger.Error(err.Error())
+		fmt.Fprintf(os.Stderr, "Error: %s\n", err.Error())
 		os.Exit(kosliErrors.ExitCodeFor(err))
 	}
 }
@@ -68,7 +68,7 @@ func innerMain(cmd *cobra.Command, args []string) error {
 					availableSubcommands = append(availableSubcommands, strings.Split(sc.Use, " ")[0])
 				}
 			}
-			logger.Error("%s\navailable subcommands are: %s", errMessage, strings.Join(availableSubcommands, " | "))
+			fmt.Fprintf(os.Stderr, "Error: %s\navailable subcommands are: %s\n", errMessage, strings.Join(availableSubcommands, " | "))
 		}
 		return kosliErrors.NewErrUsage(err.Error())
 	}

cmd/kosli/snapshotK8S_test.go

@@ -87,9 +87,9 @@ func (suite *SnapshotK8STestSuite) TestSnapshotK8SCmd() {
 			golden:    "Error: failed to read config file '/nonexistent/path.yaml': open /nonexistent/path.yaml: no such file or directory\n",
 		},
 		{
-			wantError: true,
-			name:      "snapshot K8S fails if config file has invalid YAML",
-			cmd:       fmt.Sprintf(`snapshot k8s --config-file testdata/k8s-config/invalid-yaml.yaml %s`, suite.defaultKosliArguments),
+			wantError:   true,
+			name:        "snapshot K8S fails if config file has invalid YAML",
+			cmd:         fmt.Sprintf(`snapshot k8s --config-file testdata/k8s-config/invalid-yaml.yaml %s`, suite.defaultKosliArguments),
 			goldenRegex: "Error: failed to parse config file.*",
 		},
 		{
@@ -117,9 +117,9 @@ func (suite *SnapshotK8STestSuite) TestSnapshotK8SCmd() {
 			golden:    "Error: invalid config for environment 'bad-env': cannot combine 'namespaces' with 'excludeNamespaces'\n",
 		},
 		{
-			wantError: true,
-			name:      "snapshot K8S fails if config file has invalid regex",
-			cmd:       fmt.Sprintf(`snapshot k8s --config-file testdata/k8s-config/invalid-regex.yaml %s`, suite.defaultKosliArguments),
+			wantError:   true,
+			name:        "snapshot K8S fails if config file has invalid regex",
+			cmd:         fmt.Sprintf(`snapshot k8s --config-file testdata/k8s-config/invalid-regex.yaml %s`, suite.defaultKosliArguments),
 			goldenRegex: `Error: invalid config for environment 'bad-regex-env': invalid regex '\[invalid'.*`,
 		},
 	}

cmd/kosli/testHelpers.go

@@ -11,8 +11,8 @@ import (
 	"strings"
 	"testing"
 
-	"github.com/kosli-dev/cli/internal/gitview"
 	kosliErrors "github.com/kosli-dev/cli/internal/errors"
+	"github.com/kosli-dev/cli/internal/gitview"
 	shellwords "github.com/mattn/go-shellwords"
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"

go.mod

@@ -43,6 +43,7 @@ require (
 	github.com/zalando/go-keyring v0.2.6
 	gitlab.com/gitlab-org/api/client-go v0.127.0
 	golang.org/x/oauth2 v0.34.0
+	gopkg.in/yaml.v3 v3.0.1
 	k8s.io/api v0.35.0
 	k8s.io/apimachinery v0.35.0
 	k8s.io/client-go v1.5.2
@@ -223,7 +224,6 @@ require (
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/ini.v1 v1.67.1 // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
-	gopkg.in/yaml.v3 v3.0.1 // indirect
 	k8s.io/apiextensions-apiserver v0.0.0 // indirect
 	k8s.io/apiserver v0.35.0 // indirect
 	k8s.io/component-base v0.35.0 // indirect

internal/requests/requests.go

@@ -290,6 +290,9 @@ func (c *Client) Do(p *RequestParams) (*HTTPResponse, error) {
 					cleanedErrorMessage = fmt.Sprintf("%s", respBodyMap)
 				}
 			}
+			if resp.StatusCode >= 500 {
+				return nil, kosliErrors.NewErrServer(cleanedErrorMessage)
+			}
 			if resp.StatusCode == 401 || resp.StatusCode == 403 {
 				return nil, kosliErrors.NewErrConfig(cleanedErrorMessage)
 			}