Improvements#3
Closed
sofusalbertsen wants to merge 4 commits into
Closed
Conversation
… kosli modules
The fixes in summary:
src/kosli.ts — replaced execSync(template) with spawnSync('kosli', [...args]), checked proc.error and proc.status before reading proc.stdout
src/git.ts — replaced execSync with execFileSync in all three functions, splitting each command into an args array so no shell is involved
tests/git.test.ts — updated the child_process mock from execSync → execFileSync
tests/kosli.test.ts — updated the mock from execSync → spawnSync, and updated mock return values from plain strings to the { stdout, stderr, status } shape that spawnSync actually returns
…nd improve error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.