Skip to content

Commit 639ccdd

Browse files
committed
refactor: make toJson method throw UnimplementedError()
1 parent 36318a9 commit 639ccdd

3 files changed

Lines changed: 4 additions & 11 deletions

File tree

packages/from_json_generator/test/helper/entity.dart

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,7 @@ class _FooJsonConverter implements JsonConverter<Foo, Map<String, dynamic>> {
170170
}
171171

172172
@override
173-
Map<String, dynamic> toJson(Foo foo) {
174-
return <String, dynamic>{'bar': foo.bar};
175-
}
173+
Map<String, dynamic> toJson(Foo _) => throw UnimplementedError();
176174
}
177175

178176
const _nullableFooJsonConverter = _NullableFooJsonConverter();
@@ -191,10 +189,5 @@ class _NullableFooJsonConverter
191189
}
192190

193191
@override
194-
Map<String, dynamic> toJson(Foo? foo) {
195-
if (foo == null) {
196-
return <String, dynamic>{'bar': 'defaultBar'};
197-
}
198-
return <String, dynamic>{'bar': foo.bar};
199-
}
192+
Map<String, dynamic> toJson(Foo? _) => throw UnimplementedError();
200193
}

packages/from_json_generator/test/helper/repository.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,5 @@ class _VisibilityConverter implements JsonConverter<Visibility, String> {
6666
Visibility fromJson(String json) => Visibility.fromString(json);
6767

6868
@override
69-
String toJson(Visibility visibility) => visibility.name;
69+
String toJson(Visibility _) => throw UnimplementedError();
7070
}

packages/from_json_generator/test/helper/repository_snake.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,5 +66,5 @@ class _VisibilityConverter implements JsonConverter<Visibility, String> {
6666
Visibility fromJson(String json) => Visibility.fromString(json);
6767

6868
@override
69-
String toJson(Visibility visibility) => visibility.name;
69+
String toJson(Visibility _) => throw UnimplementedError();
7070
}

0 commit comments

Comments
 (0)