change eslint+airbnb to semistandard (#24)

* change eslint+airbnb to semistandard

* fix linting errors

* submissions/kissik/port-sniffer: Fix linting errors

Author: AMashoshyna

CODE_QUALITY.md

@@ -1,23 +1,16 @@
 ### Code Quality Requirements for Homeworks
 
-The code submitted to this repository is required to be formatted with [Prettier](https://github.com/prettier/prettier) (for config details see "prettier" section in `package.json`) and match [Airbnb code style](https://github.com/airbnb/javascript).
-
-Install and use [yarn](https://yarnpkg.com/en/docs/install)
-instead of `npm`.
+The code submitted to this repository is required to match [JavaScript Standard Style](https://standardjs.com/).
 
 Please follow these steps:
-1. After cloning this repository install the dependencies (run `yarn` in project directory). This will install the following tools:
-    - eslint
-    - eslint-config-airbnb-base
-    - prettier
-    - eslint-config-prettier
-    - eslint-plugin-prettier
+1. After cloning this repository install the dependencies (run `npm install` or `yarn` in project directory). This will install the following tools:
+    - [semistandard](https://github.com/standard/semistandard) - JavaAscript Standard style guide, linter and formatted, plus semicolon requirement
 
-1. Install plugins for ESLint and Prettier for your code editor. Additionally you can enable "formatOnSave" option in your code editor, so that Prettier plugin will format your code every time you save a file.
+1. Install plugins for Semistandard code style for your code editor. Here is an [example for VSCode](https://marketplace.visualstudio.com/items?itemName=flet.vscode-semistandard). Additionally you can enable "formatOnSave" option in your code editor, so that Standard plugin will format your code every time you save a file.
 
-1. Before submitting the PR run `yarn run lint:js` and fix errors (if any).
+1. Before submitting the PR run `npm run lint:js --fix` or `yarn run lint:js --fix`. This will check your code and fix all auto-fixable errors like missing semicolons or spaces. After that fix the remaining errors (if any).
 
-1. This repository also enables ESLint change on pre-commit hook, so you should not be able to commit any code not conforming to ESLint rules.
+1. This repository also enables Standard check on pre-commit hook, so you should not be able to commit any code not conforming to ESLint rules.
 
 1. Make sure your files end with an empty line.
    Most of the IDEs are capable of doing this for you.

package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
-    "lint:js": "eslint ./submissions --ignore-pattern **/node_modules/**",
+    "lint:js": "semistandard \"submissions/**/*.js\"",
     "lint-staged": "lint-staged",
     "install:void": ":",
     "install:kissik/port-sniffer": "cd ./submissions/kissik/port-sniffer && yarn",
@@ -23,40 +23,18 @@
   },
   "homepage": "https://github.com/kottans/nodejs-2019-homeworks#readme",
   "devDependencies": {
-    "eslint": "^6.5.0",
-    "eslint-config-airbnb-base": "^14.0.0",
-    "eslint-config-prettier": "^6.3.0",
-    "eslint-plugin-import": "^2.18.2",
-    "eslint-plugin-prettier": "^3.1.1",
     "lint-staged": "^9.4.0",
     "npm-run-all": "^4.1.5",
     "pre-commit": "^1.2.2",
-    "prettier": "1.18.2"
-  },
-  "eslintConfig": {
-    "env": {
-      "node": true,
-      "es6": true
-    },
-    "extends": [
-      "airbnb-base",
-      "prettier"
-    ],
-    "parserOptions": {
-      "ecmaVersion": 2018,
-      "sourceType": "script"
-    },
-    "plugins": ["prettier"],
-    "rules": {
-      "prettier/prettier": "error"
-    }
-  },
-  "prettier": {
-    "semi": true,
-    "singleQuote": true
+    "semistandard": "^14.2.0"
   },
   "pre-commit": "lint-staged",
   "lint-staged": {
-    "*.js": "eslint"
+    "*.js": "semistandard"
+  },
+  "semistandard": {
+    "ignore": [
+      "**/node_modules/**"
+    ]
   }
 }

submissions/Zakkarat/port-sniffer/sniffer.js

@@ -83,11 +83,11 @@ const connectTo = async (host, port) => {
     });
     client.on('timeout', () => {
       client.destroy();
-      reject();
+      reject(new Error('Timeout'));
     });
     client.on('error', () => {
       client.destroy();
-      reject();
+      reject(new Error('Unknown error'));
     });
     client.connect({
       port,
@@ -122,7 +122,7 @@ const sniff = async ({ host, port, helped }) => {
   const openPorts = await checkConnection(hostPort);
   return openPorts.length
     ? console.log(`\n${openPorts.join(', ')} ports are opened`)
-    : console.log(`No ports opened`);
+    : console.log('No ports opened');
 };
 
 sniff(

submissions/eoneoff/data-structures-http/data_structures/linkedList.js

@@ -4,20 +4,20 @@
 const { Node } = require('./node');
 
 module.exports.LinkedList = class LinkedList {
-  constructor() {
+  constructor () {
     this._root = null;
     this._length = 0;
   }
 
-  *[Symbol.iterator]() {
+  * [Symbol.iterator] () {
     let current = this._root;
     while (current) {
       yield current;
       current = current.next;
     }
   }
 
-  insert(value, successor = null) {
+  insert (value, successor = null) {
     if (successor && this._root.value !== successor) {
       for (const node of this) {
         if (node.next && node.next.value === successor) {
@@ -33,7 +33,7 @@ module.exports.LinkedList = class LinkedList {
     }
   }
 
-  remove(value) {
+  remove (value) {
     if (this._root.value === value) {
       this._root = this._root.next;
       this._length--;
@@ -49,11 +49,11 @@ module.exports.LinkedList = class LinkedList {
     }
   }
 
-  showList() {
+  showList () {
     return Array.from(this, node => node.value);
   }
 
-  get length() {
+  get length () {
     return this._length;
   }
 };

submissions/eoneoff/data-structures-http/data_structures/node.js

@@ -1,23 +1,23 @@
 /* eslint-disable no-underscore-dangle */
 module.exports.Node = class Node {
-  constructor(value, next) {
+  constructor (value, next) {
     this._value = value;
     this._next = next;
   }
 
-  get value() {
+  get value () {
     return this._value;
   }
 
-  set value(value) {
+  set value (value) {
     this._value = value;
   }
 
-  get next() {
+  get next () {
     return this._next;
   }
 
-  set next(next) {
+  set next (next) {
     this._next = next;
   }
 };

submissions/eoneoff/data-structures-http/data_structures/stack.js

@@ -3,17 +3,17 @@
 const { Node } = require('./node');
 
 module.exports.Stack = class Stack {
-  constructor() {
+  constructor () {
     this._root = null;
     this._length = 0;
   }
 
-  push(value) {
+  push (value) {
     this._root = new Node(value, this._root);
     this._length++;
   }
 
-  pop() {
+  pop () {
     let out = null;
     if (this._length) {
       out = this._root.value;
@@ -23,7 +23,7 @@ module.exports.Stack = class Stack {
     return out;
   }
 
-  get length() {
+  get length () {
     return this._length;
   }
 };

submissions/eoneoff/data-structures-http/server/handler.js

@@ -2,33 +2,33 @@
 
 /* eslint-disable func-names */
 
-function isValidType(value) {
+function isValidType (value) {
   return typeof value === 'string' || typeof value === 'number';
 }
 
-function isJson(request) {
+function isJson (request) {
   return request.headers['content-type'] === 'application/json';
 }
 
-function postStack(response, stack, data) {
+function postStack (response, stack, data) {
   stack.push(data.data);
   response.writeHead(200);
   response.end();
 }
 
-function deleteStack(response, stack) {
+function deleteStack (response, stack) {
   response.writeHead(200);
   response.end(JSON.stringify({ data: stack.pop() }), {
     'Content-Type': 'application/json'
   });
 }
 
-function getList(response, list) {
+function getList (response, list) {
   response.writeHead(200, { 'Content-Type': 'application/json' });
   response.end(JSON.stringify({ data: list.showList() }));
 }
 
-function postList(response, list, data) {
+function postList (response, list, data) {
   if (!data.successor || isValidType(data.successor)) {
     try {
       list.insert(data.data, data.successor);
@@ -42,7 +42,7 @@ function postList(response, list, data) {
   response.end();
 }
 
-function deleteList(response, list, data) {
+function deleteList (response, list, data) {
   try {
     list.remove(data.data);
     response.writeHead(200);
@@ -53,22 +53,22 @@ function deleteList(response, list, data) {
   }
 }
 
-function notFound(response) {
+function notFound (response) {
   response.writeHead(404, 'Url not found');
   response.end();
 }
 
-function wrongDataType(response) {
+function wrongDataType (response) {
   response.writeHead(400, 'Wrong data type');
   response.end();
 }
 
-function wrongContentType(response) {
+function wrongContentType (response) {
   response.writeHead(400, 'Wrong content type');
   response.end();
 }
 
-function handleListOperation(request, response, list, data) {
+function handleListOperation (request, response, list, data) {
   switch (request.method) {
     case 'POST':
       postList(response, list, data);
@@ -79,7 +79,7 @@ function handleListOperation(request, response, list, data) {
   }
 }
 
-function handleJsonRequest(
+function handleJsonRequest (
   request,
   response,
   stack,
@@ -107,7 +107,7 @@ function handleJsonRequest(
 }
 
 module.exports.dataHandler = (stack, list) => {
-  return function(request, response) {
+  return function (request, response) {
     const structureType = request.url.split('/')[1];
     if (request.method === 'GET' && structureType === 'list') {
       getList(response, list);

submissions/eoneoff/data-structures-http/server/server.js

@@ -3,13 +3,13 @@ const http = require('http');
 const { dataHandler } = require('./handler');
 
 module.exports.Server = class Server {
-  constructor(stack, list) {
+  constructor (stack, list) {
     this._stack = stack;
     this._list = list;
     this._server = http.createServer(dataHandler(this._stack, this._list));
   }
 
-  run(port = 8000, host = 'localhost') {
+  run (port = 8000, host = 'localhost') {
     this._server.listen(port, host);
   }
 };