chore!: remove unmaintained libsecp256k1 crate (#127)

* chore: remove unmaintained libsecp256k1 crate

* remove useless tests and benchmarks

* remove useless tests

Author: koushiro

bip0032/AGENTS.md

@@ -63,6 +63,7 @@
 
 Generate GitHub Release notes that cover these sections:
 
-- Breaking Changes
-- New Features
+- Breaking Changes.
+- Bug Fixes.
+- New Features.
 - Performance & Behavior Improvements.

bip0032/Cargo.toml

@@ -40,15 +40,13 @@ std = [
     "zeroize/std",
     "k256?/std",
     "secp256k1?/std",
-    "libsecp256k1?/std",
     "p256?/std",
     "ed25519-dalek?/std",
 ]
 
 # BIP-0032 (secp256k1)
 k256 = ["k256/arithmetic"]
 secp256k1 = ["dep:secp256k1"]
-libsecp256k1 = ["dep:libsecp256k1"]
 
 # Optional SLIP-0010 extension (support secp256k1/nist256p1/ed25519 curve)
 slip10 = []
@@ -70,9 +68,6 @@ zeroize = { version = "1.8", default-features = false }
 k256 = { version = "0.13", default-features = false, features = ["alloc"], optional = true }
 # https://github.com/bitcoin-core/secp256k1
 secp256k1 = { version = "0.31", default-features = false, features = ["alloc"], optional = true }
-# https://github.com/paritytech/libsecp256k1
-# NOTE: libsecp256k1 crate is no longer maintained
-libsecp256k1 = { version = "0.7", default-features = false, features = ["static-context"], optional = true }
 
 ###############################################################################
 # nist256p1 libraries (SLIP-0010 extension)

bip0032/benchmarks/Cargo.toml

@@ -8,7 +8,7 @@ license.workspace = true
 publish = false
 
 [dev-dependencies]
-bip0032 = { path = "..", features = ["k256", "secp256k1", "libsecp256k1"] }
+bip0032 = { path = "..", features = ["k256", "secp256k1"] }
 bip32 = "0.5"
 bitcoin = "0.32"
 coins-bip32 = "0.13"

bip0032/benchmarks/README.md

@@ -21,8 +21,6 @@ keygen/bip32 (k256::ecdsa)
 keygen/bip0032 (k256)   time:   [1.0072 µs 1.0092 µs 1.0114 µs]
 keygen/bip0032 (secp256k1)
                         time:   [1.0158 µs 1.0178 µs 1.0201 µs]
-keygen/bip0032 (libsecp256k1)
-                        time:   [1.0726 µs 1.0743 µs 1.0762 µs]
 ```
 
 ## Derivation
@@ -43,8 +41,6 @@ derive/bip32 (k256::ecdsa)
 derive/bip0032 (k256)   time:   [216.79 µs 217.39 µs 218.06 µs]
 derive/bip0032 (secp256k1)
                         time:   [76.699 µs 80.643 µs 87.096 µs]
-derive/bip0032 (libsecp256k1)
-                        time:   [168.01 µs 168.48 µs 169.08 µs]
 ```
 
 ## Serialization
@@ -69,8 +65,6 @@ xprv_decode/bip0032 (k256)
                         time:   [5.4610 µs 5.4995 µs 5.5431 µs]
 xprv_decode/bip0032 (secp256k1)
                         time:   [5.4711 µs 5.6594 µs 5.9702 µs]
-xprv_decode/bip0032 (libsecp256k1)
-                        time:   [5.5412 µs 5.5559 µs 5.5717 µs]
 ```
 
 ### xprv encode
@@ -93,8 +87,6 @@ xprv_encode/bip0032 (k256)
                         time:   [9.8094 µs 9.8699 µs 9.9398 µs]
 xprv_encode/bip0032 (secp256k1)
                         time:   [9.7993 µs 9.8549 µs 9.9156 µs]
-xprv_encode/bip0032 (libsecp256k1)
-                        time:   [9.7966 µs 10.016 µs 10.350 µs]
 ```
 
 ### xpub decode
@@ -117,8 +109,6 @@ xpub_decode/bip0032 (k256)
                         time:   [10.942 µs 11.079 µs 11.248 µs]
 xpub_decode/bip0032 (secp256k1)
                         time:   [9.8025 µs 9.9168 µs 10.056 µs]
-xpub_decode/bip0032 (libsecp256k1)
-                        time:   [13.306 µs 14.191 µs 16.104 µs]
 ```
 
 ### xpub encode
@@ -141,6 +131,4 @@ xpub_encode/bip0032 (k256)
                         time:   [9.6266 µs 9.7398 µs 9.9000 µs]
 xpub_encode/bip0032 (secp256k1)
                         time:   [9.5780 µs 9.6362 µs 9.7008 µs]
-xpub_encode/bip0032 (libsecp256k1)
-                        time:   [9.6415 µs 9.7524 µs 9.8780 µs]
 ```

bip0032/benchmarks/src/derive.rs

@@ -101,7 +101,6 @@ fn bench_derive_bip0032(group: &mut BenchmarkGroup<'_>) {
 
     bench_impl::<K256Backend>(group, "bip0032 (k256)");
     bench_impl::<Secp256k1FfiBackend>(group, "bip0032 (secp256k1)");
-    bench_impl::<Libsecp256k1Backend>(group, "bip0032 (libsecp256k1)");
 }
 
 fn bench_derive(c: &mut Criterion) {

bip0032/benchmarks/src/keygen.rs

@@ -73,7 +73,6 @@ fn bench_keygen_bip0032(group: &mut BenchmarkGroup<'_>) {
 
     bench_impl::<K256Backend>(group, "bip0032 (k256)");
     bench_impl::<Secp256k1FfiBackend>(group, "bip0032 (secp256k1)");
-    bench_impl::<Libsecp256k1Backend>(group, "bip0032 (libsecp256k1)");
 }
 
 fn bench_keygen(c: &mut Criterion) {

bip0032/benchmarks/src/serialize/xprv_decode.rs

@@ -92,7 +92,6 @@ fn bench_bip0032(group: &mut BenchmarkGroup<'_>) {
 
     bench_impl::<K256Backend>(group, "k256");
     bench_impl::<Secp256k1FfiBackend>(group, "secp256k1");
-    bench_impl::<Libsecp256k1Backend>(group, "libsecp256k1");
 }
 
 fn bench_xprv_decode(c: &mut Criterion) {

bip0032/benchmarks/src/serialize/xprv_encode.rs

@@ -86,7 +86,6 @@ fn bench_bip0032(group: &mut BenchmarkGroup<'_>) {
 
     bench_impl::<K256Backend>(group, "k256");
     bench_impl::<Secp256k1FfiBackend>(group, "secp256k1");
-    bench_impl::<Libsecp256k1Backend>(group, "libsecp256k1");
 }
 
 fn bench_xprv_encode(c: &mut Criterion) {

bip0032/benchmarks/src/serialize/xpub_decode.rs

@@ -105,7 +105,6 @@ fn bench_bip0032(group: &mut BenchmarkGroup<'_>) {
 
     bench_impl::<K256Backend>(group, "k256");
     bench_impl::<Secp256k1FfiBackend>(group, "secp256k1");
-    bench_impl::<Libsecp256k1Backend>(group, "libsecp256k1");
 }
 
 fn bench_xpub_decode(c: &mut Criterion) {

bip0032/benchmarks/src/serialize/xpub_encode.rs

@@ -96,7 +96,6 @@ fn bench_bip0032(group: &mut BenchmarkGroup<'_>) {
 
     bench_impl::<K256Backend>(group, "k256");
     bench_impl::<Secp256k1FfiBackend>(group, "secp256k1");
-    bench_impl::<Libsecp256k1Backend>(group, "libsecp256k1");
 }
 
 fn bench_xpub_encode(c: &mut Criterion) {