Skip to content

chore(bip0039): update phf deps #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koushiro wants to merge 2 commits into from
Closed

chore(bip0039): update phf deps #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b7f52
chore(bip0039): update phf deps
koushiro Jun 25, 2026
179f9e1
Merge branch 'main' into bip0039/update-phf-deps
koushiro Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bip0039/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,15 @@ spanish = []
[dependencies]
hmac = { version = "0.13", default-features = false }
pbkdf2 = { version = "0.13", default-features = false }
phf = { version = "0.13", default-features = false }
phf = { version = "0.14", default-features = false }

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize phf_codegen with phf's layout feature

With phf 0.14, a downstream crate can enable phf/ptrhash on the shared runtime dependency through Cargo feature unification, but this crate's build script always runs phf_codegen without its matching ptrhash feature. In that consumer configuration the generated wordlist maps still emit the default CHD fields like disps, while phf::Map expects the ptrhash fields pilots/remap, so bip0039 fails to compile even though its own features did not change; either keep the 0.13 layout or force/propagate the same layout feature for both runtime and codegen.

Useful? React with 👍 / 👎.

rand = { version = "0.10", optional = true }
sha2 = { version = "0.11", default-features = false }
unicode-normalization = { version = "0.1", default-features = false }
zeroize = { version = "1.8", default-features = false, features = ["alloc"] }

[build-dependencies]
anyhow = "1.0"
phf_codegen = "0.13"
phf_codegen = "0.14"

[dev-dependencies]
const-hex = "1.17"
Expand Down
Loading