Gate release publishing#3539
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe publish workflow now restricts release-tag triggers, verifies tag and test-gate state before building, disables uv caching, and enables Docker provenance and SBOM output. ChangesPublish Workflow Release Gating
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: ci, github-actions 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📚 Docs Preview: https://pr-3539.datamodel-code-generator.pages.dev |
Merging this PR will not alter performance
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/publish.yaml (1)
198-199: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueExpect
unknown/unknownentries on the Docker Hub tag page.Enabling
provenance: mode=max+sbom: trueon a multi-platform build attaches attestation manifests to the image index, which registry UIs surface as extraunknown/unknownarchitecture rows — a known cosmetic side effect, not a build failure. Since this is a public repo, mode=max provenance is already the default, and the only build-arg exposed in provenance (VERSION) is non-sensitive, so this is purely a display consideration. If the extra entries are undesirable, they can be suppressed via annotations/output config; otherwise this is fine to keep for supply-chain metadata.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/publish.yaml around lines 198 - 199, The Docker build attestation settings in the publish workflow are causing extra unknown/unknown rows on Docker Hub, so decide whether to keep or suppress them. If you want to avoid the cosmetic entries, adjust the buildx configuration in the publish workflow to disable or redirect the provenance/SBOM output using the relevant build configuration instead of leaving provenance: mode=max and sbom: true attached to the image index; otherwise keep the current settings as-is since they’re intentional supply-chain metadata.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/publish.yaml:
- Around line 198-199: The Docker build attestation settings in the publish
workflow are causing extra unknown/unknown rows on Docker Hub, so decide whether
to keep or suppress them. If you want to avoid the cosmetic entries, adjust the
buildx configuration in the publish workflow to disable or redirect the
provenance/SBOM output using the relevant build configuration instead of leaving
provenance: mode=max and sbom: true attached to the image index; otherwise keep
the current settings as-is since they’re intentional supply-chain metadata.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a4cfa4ac-1e36-43e2-837a-40d506803477
📒 Files selected for processing (1)
.github/workflows/publish.yaml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 161 161
Lines 34363 34363
Branches 4011 4011
=========================================
Hits 34363 34363
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Breaking Change AnalysisResult: No breaking changes detected Reasoning: The PR changes only .github/workflows/publish.yaml, an internal CI/CD release workflow. It adds a "verify" release gate (tag validation and test-gate check), restricts the publish trigger to specific tag patterns instead of '', disables uv caching, and enables provenance/sbom for the Docker build. None of these affect user-facing surfaces: no changes to generated code output, Jinja2 templates, CLI options, the Python API, supported Python versions, or error handling for the tool/library. The only removed line (the '' tag glob) only affects the release automation trigger, not any user-facing behavior. Therefore there are no breaking changes. This analysis was performed by Claude Code Action |
|
🎉 Released in 0.67.0 This PR is now available in the latest release. See the release notes for details. |
Summary by CodeRabbit