Annotate ty ignores

[koxudaxi]

Summary by CodeRabbit

• Refactor
  • Updated type-checking annotations throughout the codebase to improve code quality and precision of static analysis diagnostics.

Note: This release contains no user-visible changes or new features. All modifications are internal code maintenance improvements.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d006b20a-2aa1-48b0-a39b-dd1f313a9c03

📥 Commits

Reviewing files that changed from the base of the PR and between 171783e and d9c262c.

📒 Files selected for processing (13)

• src/datamodel_code_generator/__main__.py
• src/datamodel_code_generator/dynamic.py
• src/datamodel_code_generator/input_model.py
• src/datamodel_code_generator/model/pydantic_v2/__init__.py
• src/datamodel_code_generator/model/pydantic_v2/types.py
• src/datamodel_code_generator/parser/asyncapi.py
• src/datamodel_code_generator/parser/base.py
• src/datamodel_code_generator/parser/graphql.py
• src/datamodel_code_generator/parser/openapi.py
• src/datamodel_code_generator/reference.py
• src/datamodel_code_generator/types.py
• src/datamodel_code_generator/util.py
• tests/main/test_main_general.py

---

📝 Walkthrough

Walkthrough

This PR replaces generic # type: ignore and # ty: ignore type-checker suppression comments with more specific error codes (e.g., invalid-argument-type, unresolved-attribute, invalid-assignment, redundant-cast) across the codebase. It also adds an explicit cast("Any", generation_config) when calling generate(...). No runtime logic changes.

Changes

Typing suppression refinement

Layer / File(s)	Summary
CLI generate call cast src/datamodel_code_generator/__main__.py, tests/main/test_main_general.py	run_generate_from_config now passes cast("Any", generation_config) to generate(...); matching snapshot test updated.
Dynamic model and pydantic_v2 suppressions src/datamodel_code_generator/dynamic.py, src/datamodel_code_generator/input_model.py, src/datamodel_code_generator/model/pydantic_v2/__init__.py, src/datamodel_code_generator/model/pydantic_v2/types.py	Type-ignore comments on cache assignment, model rebuild/schema loading, $defs checks, ConfigDict.dict, and strict-type assignment narrowed to specific error codes.
Parser suppressions src/datamodel_code_generator/parser/asyncapi.py, src/datamodel_code_generator/parser/base.py, src/datamodel_code_generator/parser/graphql.py, src/datamodel_code_generator/parser/openapi.py	Ignore comments on init calls, config validation, enum aliasing, resolver naming, GraphQL resolver kind/base classes, and OpenAPI field/response assignments narrowed to specific error codes.
Reference, types, and util suppressions src/datamodel_code_generator/reference.py, src/datamodel_code_generator/types.py, src/datamodel_code_generator/util.py	Ignore comments on context variable calls, cast, find_source, TOML lazy import, and CustomSafeLoader narrowed to specific error codes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• koxudaxi/datamodel-code-generator#2928: Both PRs touch run_generate_from_config's typing suppressions around the generate(...) call as part of the pyright→ty migration.
• koxudaxi/datamodel-code-generator#3384: Both PRs touch the lazy TOML loader/import logic in util.py.
• koxudaxi/datamodel-code-generator#3547: Both PRs modify type-checker suppression annotations in parser/graphql.py, including the graphql_resolver_kind path.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: updating type-ignore annotations to ty-specific suppressions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/type-ignore-comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

📚 Docs Preview: https://pr-3587.datamodel-code-generator.pages.dev

[codspeed-hq]

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 13 untouched benchmarks
⏩ 98 skipped benchmarks¹

---

_{Comparing agent/type-ignore-comments (d9c262c) with main (171783e)}

Footnotes

1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (171783e) to head (d9c262c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #3587   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines        35243     35243           
  Branches      4063      4063           
=========================================
  Hits         35243     35243           

Flag	Coverage Δ
unittests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: PR #3587 ("Annotate ty ignores") only modifies type-checker suppression comments — refining # ty: ignore to include specific diagnostic codes (e.g. [unresolved-attribute], [invalid-assignment]) and migrating # type: ignore[...] comments to # ty: ignore[...]. The single non-comment code change wraps config=generation_config in cast("Any", ...), which is a runtime no-op (typing.cast returns its argument unchanged), and the corresponding test snapshot was updated to match. No CLI options, Python API signatures, default behaviors, generated code output, Jinja2 templates, error handling, or supported Python versions are changed. There are no breaking changes.

---

This analysis was performed by Claude Code Action

[github-actions]

🎉 Released in 0.68.1

This PR is now available in the latest release. See the release notes for details.