Handle duplicate discriminator values#3603
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
📚 Docs Preview: https://pr-3603.datamodel-code-generator.pages.dev |
Merging this PR will improve performance by 18.87%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_perf_large_models_pydantic_v2_noformat |
842.7 ms | 666.3 ms | +26.48% |
| ⚡ | WallTime | test_perf_large_models_pydantic_v2_builtin |
897.6 ms | 729.4 ms | +23.06% |
| ⚡ | WallTime | test_perf_large_models_pydantic_v2 |
3.5 s | 2.9 s | +20.24% |
| ⚡ | WallTime | test_perf_openapi_large |
2.9 s | 2.5 s | +19.97% |
| ⚡ | WallTime | test_perf_multiple_files_input |
3.4 s | 2.8 s | +19.82% |
| ⚡ | WallTime | test_perf_complex_refs |
2 s | 1.6 s | +19.7% |
| ⚡ | WallTime | test_perf_all_options_enabled |
5.3 s | 4.4 s | +19.56% |
| ⚡ | WallTime | test_perf_deep_nested |
5.1 s | 4.3 s | +18.93% |
| ⚡ | WallTime | test_perf_duplicate_names |
1,031.6 ms | 870 ms | +18.58% |
| ⚡ | WallTime | test_perf_kubernetes_style_pydantic_v2 |
2.6 s | 2.2 s | +16.18% |
| ⚡ | WallTime | test_perf_graphql_style_pydantic_v2 |
778.3 ms | 675.7 ms | +15.18% |
| ⚡ | WallTime | test_perf_aws_style_openapi_pydantic_v2 |
1.9 s | 1.6 s | +14.83% |
| ⚡ | WallTime | test_perf_stripe_style_pydantic_v2 |
1.9 s | 1.7 s | +13.44% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing agent/duplicate-discriminator-values (45d46fa) with main (a425913)
Footnotes
-
98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 164 164
Lines 35526 35572 +46
Branches 4094 4105 +11
=========================================
+ Hits 35526 35572 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
No description provided.