Skip to content

Handle duplicate discriminator values#3603

Draft
koxudaxi wants to merge 2 commits into
mainfrom
agent/duplicate-discriminator-values
Draft

Handle duplicate discriminator values#3603
koxudaxi wants to merge 2 commits into
mainfrom
agent/duplicate-discriminator-values

Conversation

@koxudaxi

Copy link
Copy Markdown
Owner

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6b0a6f6b-5727-465c-80e8-b67487db2eee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/duplicate-discriminator-values

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

📚 Docs Preview: https://pr-3603.datamodel-code-generator.pages.dev

@codspeed-hq

codspeed-hq Bot commented Jul 11, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 18.87%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 13 improved benchmarks
⏩ 98 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_perf_large_models_pydantic_v2_noformat 842.7 ms 666.3 ms +26.48%
WallTime test_perf_large_models_pydantic_v2_builtin 897.6 ms 729.4 ms +23.06%
WallTime test_perf_large_models_pydantic_v2 3.5 s 2.9 s +20.24%
WallTime test_perf_openapi_large 2.9 s 2.5 s +19.97%
WallTime test_perf_multiple_files_input 3.4 s 2.8 s +19.82%
WallTime test_perf_complex_refs 2 s 1.6 s +19.7%
WallTime test_perf_all_options_enabled 5.3 s 4.4 s +19.56%
WallTime test_perf_deep_nested 5.1 s 4.3 s +18.93%
WallTime test_perf_duplicate_names 1,031.6 ms 870 ms +18.58%
WallTime test_perf_kubernetes_style_pydantic_v2 2.6 s 2.2 s +16.18%
WallTime test_perf_graphql_style_pydantic_v2 778.3 ms 675.7 ms +15.18%
WallTime test_perf_aws_style_openapi_pydantic_v2 1.9 s 1.6 s +14.83%
WallTime test_perf_stripe_style_pydantic_v2 1.9 s 1.7 s +13.44%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing agent/duplicate-discriminator-values (45d46fa) with main (a425913)

Open in CodSpeed

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a425913) to head (45d46fa).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #3603   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines        35526     35572   +46     
  Branches      4094      4105   +11     
=========================================
+ Hits         35526     35572   +46     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant