Skip to content

Additional types#185

Open
Telly86 wants to merge 4 commits into
kozakdenys:release_1.6.0from
Telly86:additional-types
Open

Additional types#185
Telly86 wants to merge 4 commits into
kozakdenys:release_1.6.0from
Telly86:additional-types

Conversation

@Telly86

@Telly86 Telly86 commented Sep 19, 2023

Copy link
Copy Markdown

Add new types for dots:

  • vertical-lines
  • horizontal-lines
  • random-dots

Add new type for corners:

  • heart

@valdruide

Copy link
Copy Markdown

NICE <3

Comment thread src/figures/dot/QRDot.ts
}
}

_drawVerticalLines({ x, y, size, getNeighbor }: DrawArgs): void {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@kozakdenys kozakdenys deleted the branch kozakdenys:release_1.6.0 October 11, 2024 13:30
@kozakdenys kozakdenys closed this Oct 11, 2024
@kozakdenys

Copy link
Copy Markdown
Owner

Sorry @Telly86, i accidentally closed your PR, reopening and review it soon, finally!

@kozakdenys kozakdenys reopened this Oct 13, 2024
@nicoschuck

Copy link
Copy Markdown

Any updates on this? The new options would be a real improvement.

@kozakdenys

Copy link
Copy Markdown
Owner

@nicoschuck, no updates yet. It is on the TODO list. I plan to resolve conflicts test and merge in the coming weeks.
I'll let you know when it's done.

@nicoschuck

Copy link
Copy Markdown

@kozakdenys Hi Denys, do you already have an update for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants