Separate test functions in Makefile and bump no-op SDK dependency#1262
Open
aravindtga wants to merge 1 commit into
Open
Separate test functions in Makefile and bump no-op SDK dependency#1262aravindtga wants to merge 1 commit into
aravindtga wants to merge 1 commit into
Conversation
✅ Deploy Preview for krm-function-catalog canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Go “no-op” function’s dependencies and refactors the Go functions Makefile to separate “test/example” functions into a dedicated list.
Changes:
- Bump
github.com/kptdev/krm-functions-sdk/go/fnfromv1.0.3tov1.0.4infunctions/go/no-op. - Add new module checksums (including
pgregory.net/rapid) togo.sum. - Split function lists in
functions/go/MakefileintoFUNCTIONSandTEST_FUNCTIONS, then combine them.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| functions/go/no-op/go.mod | Updates the KRM functions SDK dependency version. |
| functions/go/no-op/go.sum | Refreshes checksums for the updated dependency and newly pulled modules. |
| functions/go/Makefile | Separates test/example functions into TEST_FUNCTIONS and appends them to FUNCTIONS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
dosubot
Bot
added
the
size:S
aravindtga
force-pushed
the
separate-test-functions-makefile
branch
from
a778ed8 to
07cf2a3
Compare
dosubot
Bot
added
size:XS
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
separate-test-functions-makefile
branch
from
07cf2a3 to
6bb2a8d
Compare
dosubot
Bot
added
size:S
liamfallon
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FUNCTIONSvariable infunctions/go/MakefileintoFUNCTIONS(catalog functions) andTEST_FUNCTIONS(test/example functions:bar,drop-comments,foo,no-op,printenv,sleep). Also bumpedkrm-functions-sdk/go/fnfromv1.0.3tov1.0.4in theno-opfunction.TEST_FUNCTIONSis defined separately and appended toFUNCTIONSvia+=, so all targets (build, test, push, etc.) still apply to both sets.Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to split the Makefile variables and prepare the PR message.