Remove diffStripRegEx workaround in create-setters-simple test#1268
Open
aravindtga wants to merge 1 commit into
Open
Remove diffStripRegEx workaround in create-setters-simple test#1268aravindtga wants to merge 1 commit into
aravindtga wants to merge 1 commit into
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for krm-function-catalog canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a now-obsolete e2e test workaround in the create-setters-simple example by deleting the .expected/config.yaml diff-stripping configuration and updating the expected diff output to match current create-setters behavior.
Changes:
- Updated
examples/create-setters-simple/.expected/diff.patchto expect only the legitimate setter matches (removing the previously spuriouspackage-pathmatches). - Removed
examples/create-setters-simple/.expected/config.yamlwhich existed solely to strip those spurious diff lines.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/create-setters-simple/.expected/diff.patch | Updates the expected diff to reflect the corrected create-setters output (3 legitimate results only). |
| examples/create-setters-simple/.expected/config.yaml | Removes the temporary diffStripRegEx workaround configuration that is no longer needed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
diffStripRegExworkaround from thecreate-setters-simpleexample test and updated the expected diff to reflect the correct results.create-settersincorrectly matched setter values inside internal annotation paths. The fix has been released increate-settersv0.1.4, so the workaround is no longer needed..expected/config.yamland updated.expected/diff.patchto only contain the 3 legitimate setter results (removing the 2 spuriouspackage-pathmatches).Related Issue(s)
Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to identify the correct expected diff output and verify test results.