Skip to content

Remove diffStripRegEx workaround in create-setters-simple test #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aravindtga wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove diffStripRegEx workaround in create-setters-simple test #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/create-setters-simple/.expected/config.yaml
View file
Open in desktop

This file was deleted.

14 changes: 2 additions & 12 deletions examples/create-setters-simple/.expected/diff.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/Kptfile b/Kptfile
index 5aa759e..8ac91d5 100644
index 5aa759e..7ca4e2c 100644
--- a/Kptfile
+++ b/Kptfile
@@ -11,3 +11,38 @@ pipeline:
@@ -11,3 +11,28 @@ pipeline:
selectors:
- kind: Deployment
- kind: MyKind
Expand All @@ -16,11 +16,6 @@ index 5aa759e..8ac91d5 100644
+ - image: ghcr.io/kptdev/krm-functions-catalog/create-setters:latest
+ exitCode: 0
+ results:
+ - message: 'Added line comment "kpt-set: /tmp/kpt-pipeline-e2e-39110${nginx-replicas}1686/create-setters-simple" for field with value "/tmp/kpt-pipeline-e2e-3911041686/create-setters-simple"'
+ field:
+ path: metadata.annotations.internal.config.kubernetes.io/package-path
+ file:
+ path: resources.yaml
+ - message: 'Added line comment "kpt-set: ${nginx-replicas}" for field with value "4"'
+ field:
+ path: spec.replicas
Expand All @@ -36,11 +31,6 @@ index 5aa759e..8ac91d5 100644
+ path: environments
+ file:
+ path: resources.yaml
+ - message: 'Added line comment "kpt-set: /tmp/kpt-pipeline-e2e-39110${nginx-replicas}1686/create-setters-simple" for field with value "/tmp/kpt-pipeline-e2e-3911041686/create-setters-simple"'
+ field:
+ path: metadata.annotations.internal.config.kubernetes.io/package-path
+ file:
+ path: resources.yaml
diff --git a/resources.yaml b/resources.yaml
index 716ecb9..b521905 100644
--- a/resources.yaml
Expand Down
Loading