Preserve source labels/annotations on v1alpha2 CRDs during migration#1072
Open
efiacor wants to merge 1 commit into
Open
Preserve source labels/annotations on v1alpha2 CRDs during migration#1072efiacor wants to merge 1 commit into
efiacor wants to merge 1 commit into
Conversation
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
aravindtga
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Title
Preserve source labels/annotations on v1alpha2 CRDs during migration
Description
applySeedFieldsnow carries over labels and annotations from the source PackageRevision's Kubernetes metadata when creating v1alpha2 CRDs. System-managed labels (porch.kpt.dev/repository,porch.kpt.dev/latest-revision,kpt.dev/latest-revision) are excluded.Related Issue(s)
Type of Change
Checklist
Testing Instructions (Optional)
make reload-controllersE2E=1 go test ./test/e2e/crd/ -v --ginkgo.focus="Migration Metadata Preservation" -timeout 5mgo test ./controllers/repositories/pkg/controllers/repository/ -run "TestSourceMetadata|TestApplySeedFieldsWithSourceMetadata" -vAdditional Notes (Optional)
kubectl.kubernetes.io/) but keeping it minimal for nowsourceMetadatafunction is a pure helper with full unit coverage.AI Disclosure
If so, please describe how: