Ensure after-commit behaviour is explicit in tests#157
Merged
Conversation
meshy
commented
May 6, 2026
meshy
force-pushed
the
meshy/ambiguous-after-commit-execution
branch
from
485218d to
6d6d9bc
Compare
LilyFirefly
approved these changes
May 6, 2026
meshy
commented
May 6, 2026
This makes it easier to refactor in a later commit.
The logic in this function is about to get bigger, and this early return saves us from repeating the same check on each if-block.
meshy
force-pushed
the
meshy/ambiguous-after-commit-execution
branch
2 times, most recently
from
954d630 to
2af1101
Compare
LilyFirefly
approved these changes
May 7, 2026
meshy
commented
May 7, 2026
Before this change, after-commit callbacks might be silently dropped by the test suite when `run_after_commit` was used inside Django's `atomic`. While this behaviour may be desired in some tests, others might want these callbacks to run. This change ensures developers decide if after-commit callbacks should be run by ensuring the outer atomic context is opened by Subatomic in any test which calls `run_after_commit`.
meshy
force-pushed
the
meshy/ambiguous-after-commit-execution
branch
from
2af1101 to
7551249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, after-commit callbacks might be silently dropped by the test suite when
run_after_commitwas used inside Django'satomic. While this behaviour may be desired in some tests, others might want these callbacks to run.This change ensures developers decide if after-commit callbacks should be run by ensuring the outer atomic context is opened by Subatomic in any test which calls
run_after_commit.Fixes #147