Remove attrs dependency to improve import times#161
Open
RealOrangeOne wants to merge 1 commit into
Open
Conversation
This shaves around 10ms (~18%) off the import time. It removes the immutability of the exceptions, but as the exceptions are intended for dev and not to be handled, this trade-off is worthwhile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shaves around 10ms (~18%) off the import time.
It removes the immutability of the exceptions, but as the exceptions are intended for dev and not to be handled, this trade-off is worthwhile.
I've left the attribute types in place, on the off chance they're useful. It does duplicate the types for potentially little/no gain so also happy to remove.