Correctly check out the repository so validate-commits works for forks#162
Closed
RealOrangeOne wants to merge 1 commit into
Closed
Correctly check out the repository so validate-commits works for forks#162RealOrangeOne wants to merge 1 commit into
validate-commits works for forks#162RealOrangeOne wants to merge 1 commit into
Conversation
Collaborator
|
Thank you for bringing this to our attention. We've taking another approach to fixing this in #167. Please let us know if that doesn't fix it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous checkout mechanism only worked for branches on the source repository, not for forks.
This change checks out the source repository, and adds the fork as another remote which is then checked out. This keeps
mainas the upstream, and keeps the fork branch.This may do strange things if the branch isn't up-to-date with
main, but there may not be a simple way around that (outside ofvalidate-commitsitself).