Add ThreadSanitizer CI - #390
Merged
Merged
Conversation
This reverts commit 828f19a.
realFlowControl
marked this pull request as ready for review
July 22, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parallel.sofrom each pull request against that image and run a dedicated vanilla TSan job that fails on sanitizer reports.PHP version scope
TSan intentionally runs only on PHP 8.5. PHP 8.4 and older load extensions with
RTLD_DEEPBIND, which is incompatible with the sanitizer runtime. PHP 8.5 stopped usingRTLD_DEEPBINDfor the CLI whendlmopen()is available, allowing TSan to instrument PHP andparallel.sowithout carrying a patched PHP build.Verification
ghcr.io/krakjoe/php-tsan-8.5:8.5.8and confirmed the image starts successfully under TSan.Addressed findings
php_parallel_monitor_check()previously readphp_parallel_monitor_t::statewithout synchronization while writers held the monitor mutex. The state is now consistently protected by the recursive monitor mutex instead of relying onvolatile.The SAPI bailout recovery previously unlocked
php_parallel_output_mutexafter every unclean shutdown, including cancellation bailouts where the current thread did not own the mutex. Thread-local ownership now limits recovery to bailouts that interrupted the SAPI writer while preserving the FrankenPHP client-disconnect behavior from #313.