Add attributes m_collisionFilterGroup, m_collisionFilterMask to ContactResultCallback in ammo.idl#352
Open
regnaio wants to merge 5 commits into
Open
Add attributes m_collisionFilterGroup, m_collisionFilterMask to ContactResultCallback in ammo.idl#352regnaio wants to merge 5 commits into
regnaio wants to merge 5 commits into
Conversation
Collaborator
|
Looks like CI is breaking because of deprecated code in https://github.com/mymindstorm/setup-emsdk. I'll work on getting this fixed later today... thanks! |
Collaborator
Author
|
Thank you, @ianpurvis! Just merged ammo.js master into this PR branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #350
Please refer to the bullet source code for
ContactResultCallback: https://github.com/kripken/ammo.js/blob/master/bullet/src/BulletCollision/CollisionDispatch/btCollisionWorld.h#L411Note how the
ContactResultCallbackconstructor automatically setsm_collisionFilterGrouptobtBroadphaseProxy::DefaultFilter(value 1) andm_collisionFilterMasktobtBroadphaseProxy::AllFilter(value -1)ContactResultCallbackuses these 2 attributes inneedsCollision()to determine whetheraddSingleResult(...)should be triggeredThus, without the 2 added attributes in this PR, we cannot control when
addSingleResultis triggered bycontactTest, especially when using collision filter groups and masks on ourbtRigidBodysCould we please add these 2 attributes to
ammo.idl? Thank you for your time and help!(Note that the build files were generated using the command
cmake -B builds -DCLOSURE=1 -DTOTAL_MEMORY=268435456with the environment based on the Dockerfile in #351 (comment). Please disregard these build files if another configuration is preferred)