Make compatible with NWJS#420
Open
Neptilo wants to merge 1 commit into
Open
Conversation
Author
|
Hi Will,
I don't understand. The URL you sent precisely refers to the same repo that
I forked. How would those edits be overwritten?
…On Thu, 14 Sept 2023 at 18:26, Will Eastcott ***@***.***> wrote:
Thanks for this. But we take ammo.js from this repo:
https://github.com/kripken/ammo.js/tree/main/builds
We'll no doubt grab updates from there over time and we'll likely lose
these edits. Have you considered posting an issue on the ammo.js repo to
say you'd like the builds to be compatible with NWJS?
—
Reply to this email directly, view it on GitHub
<#420 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGMBLKZILQPUXDIORU434TX2MV2HANCNFSM6AAAAAA4YMGX5I>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
@Neptilo Ignore that previous (since-deleted) message. I mistakenly thought this was logged on the PlayCanvas repo - and, of course, it isn't. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In NWJS,
__dirnamedoesn't exist in the global scope but in a namespace calledglobal.