Add redirects for QR codes.#200
Conversation
Includes adding a `latest` as a special version. Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
| fromVersion: 0.15.0 | ||
| path: /html/kroxylicious-proxy/#assembly-configuring-proxy-proxy | ||
| - name: current25-operator | ||
| fromVersion: 0.14.0 |
There was a problem hiding this comment.
First version the guide appeared in but 0.16.0 is all I need to work right now.
Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
robobario
left a comment
There was a problem hiding this comment.
LGTM thanks @SamBarker
Non-blocking: I worry we'll put out some new documentation version which causes the redirect to 404. Also we don't have much protection against someone refactoring and accidentally altering or removing the desired http://localhost:4000/redirect/qr-codes/latest/current25-configuring-the-proxy.html
Doesn't have to be in this PR but adding something to check that the build produces redirect/qr-codes/latest/current25-configuring-the-proxy.html could be good. Even better if we can check the link is good.
In the past I've played with https://github.com/lycheeverse/lychee which is a pretty good way to follow all the links, very easy to hit 3rd party rate limits though 😁
Yeah thats all good points, I don't have the cycles today to deal with it but yes breaking the links would be a bad move. |
Includes adding a
latestas a special version.I want to add some QR codes to link to our docs as part of my current talk however given there is likely to be a release soon I think they should point to the latest and greatest version.