Skip to content

Add redirects for QR codes.#200

Merged
SamBarker merged 2 commits into
kroxylicious:mainfrom
SamBarker:add-qr-codes-redirtect
Oct 22, 2025
Merged

Add redirects for QR codes.#200
SamBarker merged 2 commits into
kroxylicious:mainfrom
SamBarker:add-qr-codes-redirtect

Conversation

@SamBarker

Copy link
Copy Markdown
Member

Includes adding a latest as a special version.

I want to add some QR codes to link to our docs as part of my current talk however given there is likely to be a release soon I think they should point to the latest and greatest version.

Includes adding a `latest` as a special version.

Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
@SamBarker SamBarker requested a review from a team as a code owner October 21, 2025 08:25
fromVersion: 0.15.0
path: /html/kroxylicious-proxy/#assembly-configuring-proxy-proxy
- name: current25-operator
fromVersion: 0.14.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 0.14.0?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First version the guide appeared in but 0.16.0 is all I need to work right now.

Signed-off-by: Sam Barker <sam@quadrocket.co.uk>

@robobario robobario left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @SamBarker

Non-blocking: I worry we'll put out some new documentation version which causes the redirect to 404. Also we don't have much protection against someone refactoring and accidentally altering or removing the desired http://localhost:4000/redirect/qr-codes/latest/current25-configuring-the-proxy.html

Doesn't have to be in this PR but adding something to check that the build produces redirect/qr-codes/latest/current25-configuring-the-proxy.html could be good. Even better if we can check the link is good.

In the past I've played with https://github.com/lycheeverse/lychee which is a pretty good way to follow all the links, very easy to hit 3rd party rate limits though 😁

@SamBarker SamBarker merged commit e4e5078 into kroxylicious:main Oct 22, 2025
2 checks passed
@SamBarker

Copy link
Copy Markdown
Member Author

Non-blocking: I worry we'll put out some new documentation version which causes the redirect to 404. Also we don't have much protection against someone refactoring and accidentally altering or removing the desired http://localhost:4000/redirect/qr-codes/latest/current25-configuring-the-proxy.html

Doesn't have to be in this PR but adding something to check that the build produces redirect/qr-codes/latest/current25-configuring-the-proxy.html could be good. Even better if we can check the link is good.

In the past I've played with https://github.com/lycheeverse/lychee which is a pretty good way to follow all the links, very easy to hit 3rd party rate limits though 😁

Yeah thats all good points, I don't have the cycles today to deal with it but yes breaking the links would be a bad move.

@SamBarker SamBarker deleted the add-qr-codes-redirtect branch October 22, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants