Use __lg to make treeJump shorter#260
Open
IvanRenison wants to merge 2 commits into
Open
Conversation
It breaks the case when P is empty, but thats not an useful case
Member
|
I don't care about the case of empty P, because that's not a tree, but I do care about sz(P) == 1. __lg(0) is undefined, right? |
Contributor
Author
|
Oh, yes, I saw in this stack overflow answer that it's -1, and in my machine gives -1, but according to this codeforces blog you are right. |
Contributor
|
if sz(P)==1 then __lg(1)=0 and is not UB, so original code would have worked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It breaks the case when P is empty, but thats not an useful case