Simplify MCMF#317
Open
Matistjati wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I considered what would happen if we replace the pbds priority queue with a normal priority_queue, mostly because in my experience, the PBDS is usually slower. As it turns out, it's not that bad. Compare std pq vs pbds pq (current KACTL) here.
So overall, the tradeoff is ~10% slower performance to gain a more slightly more understandable and shorter implementation. I think I will merge this into my personal TRD, but if you don't feel the tradeoff is worth it, feel free to close this PR.