Optimize and make Modint safer#318
Merged
simonlindholm merged 1 commit intoJun 23, 2026
Merged
Conversation
832903c to
53f5a20
Compare
simonlindholm
approved these changes
Jun 23, 2026
| assert(g == 1); return x; | ||
| } | ||
| Mod operator^(ll e) { | ||
| if (!e) return Mod(1); |
Member
There was a problem hiding this comment.
Suggested change
| if (!e) return Mod(1); | |
| if (!e) return 1; |
also works, right?
96ad8ab
into
kth-competitive-programming:main
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old modint was slightly footgunny because it didn't normalize in the constructor, so you could get un-normalized Mod structs if you passed numbers outside of$[0,mod)$ . It's quite easy to miss this, especially if the input may contain negative numbers. To avoid performance regression from modding in the constructor, I add an "internal" constructor. The code is noticably faster for
+and-.*should be about the same. The number of non-whitespace characters increases by 5.