Skip to content

KTOR-9513 Honour the max argument for decode#5543

Draft
bjhham wants to merge 1 commit into
release/3.xfrom
bjhham/max-decode
Draft

KTOR-9513 Honour the max argument for decode#5543
bjhham wants to merge 1 commit into
release/3.xfrom
bjhham/max-decode

Conversation

@bjhham
Copy link
Copy Markdown
Contributor

@bjhham bjhham commented Apr 21, 2026

Subsystem
Server, Core

Motivation
KTOR-9513 CharsetDecoder.decode() ignores the max argument on JVM

Solution
Just passed the max into the kotlinx-io reads. I don't know why we weren't processing it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4312ed09-0ec5-4934-8bba-06619fbbfc60

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bjhham/max-decode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant