Implement chemical quantities including ActivationEnergy, AmountOfSubstance, Concentration, DynamicViscosity, EnzymeActivity, MolarMass, PH, RateConstant, ReactionRate, and SurfaceTension. Update PhysicalDimensions and Units to include new chemical dimensions and units. Mark the Chemical domain as fully implemented in TODO_DOMAINS.md, enhancing the completeness of the quantities implementation.

Author: matt-edmondson

.cursor/rules/derived-cursor-rules.mdc

@@ -243,6 +243,12 @@ When adding XML documentation comments:
     2.  Remove the `BaseUnit` property from `PhysicalQuantity` and its interface.
     3.  Update `PhysicalQuantity.In()` to use `Dimension.BaseUnit`.
 *   When implementing PhysicalQuantity classes, ensure the containing type is one of the parameters in the generic type definition.
+*   When creating new quantities, implement the following:
+    *   Add any necessary dimensions to `PhysicalDimensions.cs`.
+    *   Add any new units to `Units.cs`.
+    *   Follow the existing code style and patterns.
+    *   Include XML documentation comments.
+    *   Implement mathematical relationships between related quantities.
 
 ## DEBUGGING
 
@@ -319,6 +325,12 @@ When adding XML documentation comments:
 *   When encountering CS0108 errors, 'SoundPressureLevel<T>.Create(T)' hides inherited member, add the `new` keyword if hiding was intended.
 *   When encountering CS0200 errors, Property or indexer 'PhysicalQuantity<SoundIntensityLevel<T>, T>.Value' cannot be assigned to -- it is read only, make sure you are not trying to assign to a read-only property.
 *   When encountering CA1062 errors, In externally visible method 'SoundPressureLevel<T> SoundPressureLevel<T>.FromSoundPressure(SoundPressure<T> soundPressure)', validate parameter 'soundPressure' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null' add a null check for the reference parameter.
+*   When fixing CS0704 errors (Cannot do non-virtual member lookup in 'T' because it is a type parameter), add the appropriate generic constraints (e.g., `where T : struct, INumber<T>, IFloatingPoint<T>`).
+*   When fixing CA1062 errors (In externally visible method X, validate parameter Y is non-null before using it), add `ArgumentNullException.ThrowIfNull(parameterName)` at the beginning of the method.
+*   When a file is missing the standard header, add the following to the top of the file:
+```csharp
+// Copyright (c) KTSU. All rights reserved.
+```
 
 ## WORKFLOW & RELEASE RULES
 
@@ -339,9 +351,4 @@ When adding XML documentation comments:
 *   For ease of use, use a single common namespace for all types in the library.
 *   SemanticStringValidationExamples can just be built in semantic types where appropriate
 *   The built in semantic string types should not need the string suffix.
-*   Instead of creating generic built-in types like `Base64String`, use validation attributes like `[IsBase64]`, `[IsGuid]`, `[IsEmailAddress]` etc. that can be applied to domain-specific semantic string types.
-*   Validation attributes should be separated into their own files.
-*   Instead of creating generic built-in types like `Base6String`, use validation attributes like `[IsBase64]`, `[IsGuid]`, `[IsEmailAddress]` etc. that can be applied to domain-specific semantic string types.
-*   The built in semantic string types are too niche or too simple, create a collection of useful builtin semantic string types with appropriate validations, where they aren't already implemented in dotnet, like Uri is.
-*   Validation attributes should be separated into their own files.
-*   Instead of creating generic built-in types like `Base64String`, use validation attributes like `[IsBase64]`, `[IsGuid]`, `[IsEmailAddress]` etc
+*

.specstory/history/2025-06-12_03-24-tasks-for-completing-quantities-implementation.md

@@ -1,4 +1,6 @@
-// Copyright (c) KTSU. All rights reserved.
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
 
 namespace ktsu.Semantics;
 
@@ -10,7 +12,7 @@ namespace ktsu.Semantics;
 /// </summary>
 /// <typeparam name="T">The numeric type for the activation energy value.</typeparam>
 public sealed record ActivationEnergy<T> : PhysicalQuantity<ActivationEnergy<T>, T>
-	where T : struct, INumber<T>
+	where T : struct, INumber<T>, IFloatingPoint<T>
 {
 	/// <summary>Gets the physical dimension of activation energy [M L² T⁻² N⁻¹].</summary>
 	public override PhysicalDimension Dimension => PhysicalDimensions.ActivationEnergy;
@@ -38,7 +40,7 @@ public static ActivationEnergy<T> FromArrheniusPlot(RateConstant<T> rateConstant
 		T t2 = temperature2.In(Units.Kelvin);
 		T gasConstant = T.CreateChecked(8.314); // J/(mol·K)
 
-		T lnRatio = T.Log(k2 / k1);
+		T lnRatio = T.CreateChecked(Math.Log(double.CreateChecked(k2 / k1)));
 		T tempDifference = (T.One / t1) - (T.One / t2);
 		T ea = -gasConstant * lnRatio / tempDifference;
 		return Create(ea);
@@ -80,7 +82,7 @@ public T CalculateRateRatio(Temperature<T> temperature1, Temperature<T> temperat
 		T t2 = temperature2.In(Units.Kelvin);
 		T gasConstant = T.CreateChecked(8.314); // J/(mol·K)
 
-		T exponent = (ea / gasConstant) * ((T.One / t1) - (T.One / t2));
-		return T.Exp(exponent);
+		T exponent = ea / gasConstant * ((T.One / t1) - (T.One / t2));
+		return T.CreateChecked(Math.Exp(double.CreateChecked(exponent)));
 	}
 }

Semantics/Quantities/Chemical/ActivationEnergy.cs

@@ -1,4 +1,6 @@
-// Copyright (c) KTSU. All rights reserved.
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
 
 namespace ktsu.Semantics;
 
@@ -43,6 +45,7 @@ public T GetNumberOfEntities()
 	/// <returns>The mass of the substance.</returns>
 	public Mass<T> CalculateMass(MolarMass<T> molarMass)
 	{
+		ArgumentNullException.ThrowIfNull(molarMass);
 		T molesValue = In(Units.Mole);
 		T molarMassValue = molarMass.In(Units.GramPerMole);
 		T massInGrams = molesValue * molarMassValue;

Semantics/Quantities/Chemical/AmountOfSubstance.cs

@@ -1,3 +1,7 @@
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
+
 namespace ktsu.Semantics;
 
 using System.Numerics;
@@ -22,6 +26,8 @@ public Concentration() : base() { }
 	/// <returns>The molarity (mol/L).</returns>
 	public static Concentration<T> FromMolarity(AmountOfSubstance<T> amountOfSubstance, Volume<T> volume)
 	{
+		ArgumentNullException.ThrowIfNull(amountOfSubstance);
+		ArgumentNullException.ThrowIfNull(volume);
 		T moles = amountOfSubstance.In(Units.Mole);
 		T liters = volume.In(Units.Liter);
 		T molarity = moles / liters;
@@ -34,6 +40,8 @@ public static Concentration<T> FromMolarity(AmountOfSubstance<T> amountOfSubstan
 	/// <returns>The concentration in ppm.</returns>
 	public static Concentration<T> FromPartsPerMillion(Mass<T> soluteMass, Mass<T> solutionMass)
 	{
+		ArgumentNullException.ThrowIfNull(soluteMass);
+		ArgumentNullException.ThrowIfNull(solutionMass);
 		T soluteGrams = soluteMass.In(Units.Gram);
 		T solutionGrams = solutionMass.In(Units.Gram);
 		T ratio = soluteGrams / solutionGrams;
@@ -47,6 +55,8 @@ public static Concentration<T> FromPartsPerMillion(Mass<T> soluteMass, Mass<T> s
 	/// <returns>The concentration in % w/v.</returns>
 	public static Concentration<T> FromWeightVolumePercent(Mass<T> soluteMass, Volume<T> solutionVolume)
 	{
+		ArgumentNullException.ThrowIfNull(soluteMass);
+		ArgumentNullException.ThrowIfNull(solutionVolume);
 		T massGrams = soluteMass.In(Units.Gram);
 		T volumeML = solutionVolume.In(Units.Milliliter);
 		T ratio = massGrams / volumeML;
@@ -60,10 +70,12 @@ public static Concentration<T> FromWeightVolumePercent(Mass<T> soluteMass, Volum
 	/// <returns>The final concentration after dilution.</returns>
 	public Concentration<T> Dilute(Volume<T> initialVolume, Volume<T> finalVolume)
 	{
+		ArgumentNullException.ThrowIfNull(initialVolume);
+		ArgumentNullException.ThrowIfNull(finalVolume);
 		T c1 = In(Units.Molar);
 		T v1 = initialVolume.In(Units.Liter);
 		T v2 = finalVolume.In(Units.Liter);
-		T c2 = (c1 * v1) / v2;
+		T c2 = c1 * v1 / v2;
 		return Create(c2);
 	}
 }

Semantics/Quantities/Chemical/Concentration.cs

@@ -1,4 +1,6 @@
-// Copyright (c) KTSU. All rights reserved.
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
 
 namespace ktsu.Semantics;
 

Semantics/Quantities/Chemical/DynamicViscosity.cs

@@ -1,4 +1,6 @@
-// Copyright (c) KTSU. All rights reserved.
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
 
 namespace ktsu.Semantics;
 

Semantics/Quantities/Chemical/EnzymeActivity.cs

@@ -1,4 +1,6 @@
-// Copyright (c) KTSU. All rights reserved.
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
 
 namespace ktsu.Semantics;
 

Semantics/Quantities/Chemical/MolarMass.cs

@@ -1,4 +1,6 @@
-// Copyright (c) KTSU. All rights reserved.
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
 
 namespace ktsu.Semantics;
 
@@ -10,7 +12,7 @@ namespace ktsu.Semantics;
 /// </summary>
 /// <typeparam name="T">The numeric type for the rate constant value.</typeparam>
 public sealed record RateConstant<T> : PhysicalQuantity<RateConstant<T>, T>
-	where T : struct, INumber<T>
+	where T : struct, INumber<T>, IFloatingPoint<T>
 {
 	/// <summary>Gets the physical dimension of rate constant [T⁻¹] for first-order reactions.</summary>
 	public override PhysicalDimension Dimension => PhysicalDimensions.RateConstant;
@@ -34,7 +36,7 @@ public static RateConstant<T> FromArrheniusEquation(T preExponentialFactor,
 		T gasConstant = T.CreateChecked(8.314); // J/(mol·K)
 
 		T exponent = -ea / (gasConstant * temp);
-		T k = preExponentialFactor * T.Exp(exponent);
+		T k = preExponentialFactor * T.CreateChecked(Math.Exp(double.CreateChecked(exponent)));
 		return Create(k);
 	}
 
@@ -56,8 +58,8 @@ public RateConstant<T> AtTemperature(Temperature<T> temperature1, Temperature<T>
 		T ea = activationEnergy.In(Units.JoulesPerMole);
 		T gasConstant = T.CreateChecked(8.314); // J/(mol·K)
 
-		T exponent = (ea / gasConstant) * ((T.One / t1) - (T.One / t2));
-		T ratio = T.Exp(exponent);
+		T exponent = ea / gasConstant * ((T.One / t1) - (T.One / t2));
+		T ratio = T.CreateChecked(Math.Exp(double.CreateChecked(exponent)));
 		T k2 = k1 * ratio;
 		return Create(k2);
 	}

Semantics/Quantities/Chemical/RateConstant.cs

@@ -1,4 +1,6 @@
-// Copyright (c) KTSU. All rights reserved.
+// Copyright (c) ktsu.dev
+// All rights reserved.
+// Licensed under the MIT license.
 
 namespace ktsu.Semantics;
 
@@ -10,7 +12,7 @@ namespace ktsu.Semantics;
 /// </summary>
 /// <typeparam name="T">The numeric type for the reaction rate value.</typeparam>
 public sealed record ReactionRate<T> : PhysicalQuantity<ReactionRate<T>, T>
-	where T : struct, INumber<T>
+	where T : struct, INumber<T>, IFloatingPoint<T>
 {
 	/// <summary>Gets the physical dimension of reaction rate [N L⁻³ T⁻¹].</summary>
 	public override PhysicalDimension Dimension => PhysicalDimensions.ReactionRate;
@@ -52,7 +54,7 @@ public static ReactionRate<T> FromRateLaw(RateConstant<T> rateConstant,
 		T cA = concentrationA.In(Units.Molar);
 		T cB = concentrationB.In(Units.Molar);
 
-		T rateValue = k * T.Pow(cA, orderA) * T.Pow(cB, orderB);
+		T rateValue = k * T.CreateChecked(Math.Pow(double.CreateChecked(cA), double.CreateChecked(orderA))) * T.CreateChecked(Math.Pow(double.CreateChecked(cB), double.CreateChecked(orderB)));
 		return Create(rateValue);
 	}
 
@@ -72,7 +74,7 @@ public RateConstant<T> CalculateRateConstant(Concentration<T> concentrationA, Co
 		T cA = concentrationA.In(Units.Molar);
 		T cB = concentrationB.In(Units.Molar);
 
-		T denominator = T.Pow(cA, orderA) * T.Pow(cB, orderB);
+		T denominator = T.CreateChecked(Math.Pow(double.CreateChecked(cA), double.CreateChecked(orderA))) * T.CreateChecked(Math.Pow(double.CreateChecked(cB), double.CreateChecked(orderB)));
 		T k = rate / denominator;
 		return RateConstant<T>.Create(k);
 	}