Skip to content

Remove explicit string conversion operators in favor of .As<T>() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-edmondson merged 3 commits into from
Jun 18, 2025
Merged

Remove explicit string conversion operators in favor of .As<T>() #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33aed97
Update package versions and refine project metadata
matt-edmondson Jun 18, 2025
917c0b8
Refactor performance regression tests to set CI-friendly targets
matt-edmondson Jun 18, 2025
5a2dfa8
Refactor exception assertions in unit tests for consistency
matt-edmondson Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@
*.woff2 filter=lfs diff=lfs merge=lfs -text

# Other
*.exe filter=lfs diff=lfs merge=lfs -text
*.exe filter=lfs diff=lfs merge=lfs -text
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,4 +643,5 @@ Temporary Items
# SpecStory explanation file
/.what-is-this.md
# SpecStory derived-cursor-rules.mdc backup files
/ai_rules_backups/*
.specstory/ai_rules_backups/*
1 change: 0 additions & 1 deletion .mailmap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> <act
ktsu[bot] <ProjectDirector@ktsu.dev>
ktsu[bot] <SyncFileContents>
Damon3000s <damon@thethreethousands.com>

1 change: 1 addition & 0 deletions .specstory/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,4 +643,5 @@ Temporary Items
# SpecStory explanation file
/.what-is-this.md
# SpecStory derived-cursor-rules.mdc backup files
/ai_rules_backups/*
.specstory/ai_rules_backups/*
18 changes: 6 additions & 12 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="BenchmarkDotNet" Version="0.15.1" />
<PackageVersion Include="BenchmarkDotNet" Version="0.14.0" />
<PackageVersion Include="CommandLineParser" Version="2.9.1" />
<PackageVersion Include="ktsu.Extensions" Version="1.5.6" />
<PackageVersion Include="ktsu.SemanticString" Version="1.4.0" />
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
<PackageVersion Include="coverlet.msbuild" Version="6.0.4" />
<PackageVersion Include="DiffPlex" Version="1.8.0" />
Expand All @@ -13,18 +15,10 @@
<PackageVersion Include="ImGui.NET" Version="1.91.6.1" />
<PackageVersion Include="ktsu.AppDataStorage" Version="1.15.6" />
<PackageVersion Include="ktsu.CaseConverter" Version="1.3.2" />
<PackageVersion Include="ktsu.Extensions" Version="1.5.6" />
<PackageVersion Include="ktsu.FuzzySearch" Version="1.2.1" />
<PackageVersion Include="ktsu.ImGuiStyler" Version="1.3.2" />
<PackageVersion Include="ktsu.ScopedAction" Version="1.1.2" />
<PackageVersion Include="ktsu.Semantics" Version="1.0.16" />
<PackageVersion Include="ktsu.SemanticString" Version="1.2.18" />
<PackageVersion Include="ktsu.StrongPaths" Version="1.3.2" />
<PackageVersion Include="ktsu.StrongPaths" Version="1.3.1" />
<PackageVersion Include="ktsu.StrongStrings" Version="1.4.2" />
<PackageVersion Include="ktsu.TextFilter" Version="1.5.3" />
<PackageVersion Include="ktsu.ToStringJsonConverter" Version="1.2.4" />
<PackageVersion Include="ktsu.RoundTripStringStringJsonConverter" Version="1.0.1" />
<PackageVersion Include="MessagePack" Version="3.1.4" />
<PackageVersion Include="ktsu.ToStringJsonConverter" Version="1.2.3" />
<PackageVersion Include="MessagePack" Version="3.0.3" />
<PackageVersion Include="Microsoft.Build" Version="17.14.8" />
<PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.14.8" />
<PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="9.0.6" />
Expand Down
2 changes: 1 addition & 1 deletion Semantics.Test/AdvancedErrorScenarioTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
using Microsoft.VisualStudio.TestTools.UnitTesting;

[TestClass]
public static class AdvancedErrorScenarioTests

Check warning on line 12 in Semantics.Test/AdvancedErrorScenarioTests.cs

View workflow job for this annotation

GitHub Actions / Build, Test & Release 

Add some tests to this class. (https://rules.sonarsource.com/csharp/RSPEC-2187)
{
[TestClass]
public class SemanticQuantityErrorTests
Expand Down Expand Up @@ -156,7 +156,7 @@
Assert.AreEqual("Test", testString.WeakString);

// Should fail with different case
Assert.ThrowsException<ArgumentException>(() =>
Assert.ThrowsExactly<ArgumentException>(() =>
SemanticString<CaseTestString>.Create<CaseTestString>("test"));
}

Expand Down Expand Up @@ -224,7 +224,7 @@
private sealed partial record TestDirectoryPath : SemanticDirectoryPath<TestDirectoryPath> { }

[TestMethod]
[ExpectedException(typeof(ArgumentException))]

Check warning on line 227 in Semantics.Test/AdvancedErrorScenarioTests.cs

View workflow job for this annotation

GitHub Actions / Build, Test & Release 

Replace the 'ExpectedException' attribute with a throw assertion or a try/catch block. (https://rules.sonarsource.com/csharp/RSPEC-3431)
public void SemanticPath_InvalidCharacters_ShouldThrow()
{
char[] invalidChars = Path.GetInvalidPathChars();
Expand Down Expand Up @@ -423,7 +423,7 @@
PooledStringBuilder.Return(sb); // Double return should be safe
}

Assert.IsTrue(true, "Double return should not cause issues");

Check warning on line 426 in Semantics.Test/AdvancedErrorScenarioTests.cs

View workflow job for this annotation

GitHub Actions / Build, Test & Release 

Remove or correct this assertion. (https://rules.sonarsource.com/csharp/RSPEC-2701)
}
}
}
38 changes: 19 additions & 19 deletions Semantics.Test/PerformanceRegressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public class PerformanceRegressionTests

/// <summary>
/// Performance baseline for basic quantity creation across all domains.
/// Target: > 1M operations/second per domain.
/// Target: > 1M operations/second per domain (CI-friendly).
/// </summary>
[TestMethod]
public void PerformanceBaseline_QuantityCreation()
Expand Down Expand Up @@ -61,9 +61,9 @@ public void PerformanceBaseline_QuantityCreation()

Console.WriteLine($"{domain.Key} creation: {operationsPerSecond:F0} ops/sec");

// Performance regression test - should be > 2.8M ops/sec
Assert.IsTrue(operationsPerSecond > 2800000,
$"{domain.Key} quantity creation performance regression: {operationsPerSecond:F0} ops/sec < 2.8M ops/sec");
// Performance regression test - should be > 1M ops/sec (CI-friendly target)
Assert.IsTrue(operationsPerSecond > 1000000,
$"{domain.Key} quantity creation performance regression: {operationsPerSecond:F0} ops/sec < 1M ops/sec");
}

// Overall performance should be consistent across domains (within 50% variance)
Expand All @@ -78,7 +78,7 @@ public void PerformanceBaseline_QuantityCreation()

/// <summary>
/// Performance baseline for unit conversions.
/// Target: > 9M conversions/second.
/// Target: > 3M conversions/second (CI-friendly).
/// </summary>
[TestMethod]
public void PerformanceBaseline_UnitConversions()
Expand All @@ -105,14 +105,14 @@ public void PerformanceBaseline_UnitConversions()
double performance = MeasurePerformance(conversion.action, MediumIterationCount);
Console.WriteLine($"{conversion.name}: {performance:F0} ops/sec");

Assert.IsTrue(performance > 9000000,
$"Conversion performance regression: {conversion.name} = {performance:F0} ops/sec < 9M ops/sec");
Assert.IsTrue(performance > 3000000,
$"Conversion performance regression: {conversion.name} = {performance:F0} ops/sec < 3M ops/sec");
}
}

/// <summary>
/// Performance baseline for arithmetic operations between quantities.
/// Target: > 2.5M operations/second for basic arithmetic.
/// Target: > 1M operations/second for basic arithmetic (CI-friendly).
/// </summary>
[TestMethod]
public void PerformanceBaseline_ArithmeticOperations()
Expand Down Expand Up @@ -151,14 +151,14 @@ public void PerformanceBaseline_ArithmeticOperations()
double performance = MeasurePerformance(test.action, LargeIterationCount);
Console.WriteLine($"{test.name}: {performance:F0} ops/sec");

Assert.IsTrue(performance > 2500000,
$"Arithmetic operation performance regression: {test.name} = {performance:F0} ops/sec < 2.5M ops/sec");
Assert.IsTrue(performance > 1000000,
$"Arithmetic operation performance regression: {test.name} = {performance:F0} ops/sec < 1M ops/sec");
}
}

/// <summary>
/// Performance baseline for physics relationship calculations.
/// Target: > 2.2M operations/second for complex physics calculations.
/// Target: > 800K operations/second for complex physics calculations (CI-friendly).
/// </summary>
[TestMethod]
public void PerformanceBaseline_PhysicsRelationships()
Expand Down Expand Up @@ -199,14 +199,14 @@ public void PerformanceBaseline_PhysicsRelationships()
double performance = MeasurePerformance(test.action, MediumIterationCount);
Console.WriteLine($"{test.name}: {performance:F0} ops/sec");

Assert.IsTrue(performance > 2200000,
$"Physics relationship performance regression: {test.name} = {performance:F0} ops/sec < 2.2M ops/sec");
Assert.IsTrue(performance > 800000,
$"Physics relationship performance regression: {test.name} = {performance:F0} ops/sec < 800K ops/sec");
}
}

/// <summary>
/// Performance baseline for physical constant access.
/// Target: > 50M operations/second for constant access.
/// Target: > 15M operations/second for constant access (CI-friendly).
/// </summary>
[TestMethod]
public void PerformanceBaseline_ConstantAccess()
Expand All @@ -232,14 +232,14 @@ public void PerformanceBaseline_ConstantAccess()
double performance = MeasurePerformance(test.action, LargeIterationCount);
Console.WriteLine($"{test.name}: {performance:F0} ops/sec");

Assert.IsTrue(performance > 50000000,
$"Constant access performance regression: {test.name} = {performance:F0} ops/sec < 50M ops/sec");
Assert.IsTrue(performance > 15000000,
$"Constant access performance regression: {test.name} = {performance:F0} ops/sec < 15M ops/sec");
}
}

/// <summary>
/// Performance baseline for cross-domain calculations.
/// Target: > 1M operations/second for multi-domain scenarios.
/// Target: > 500K operations/second for multi-domain scenarios (CI-friendly).
/// </summary>
[TestMethod]
public void PerformanceBaseline_CrossDomainCalculations()
Expand Down Expand Up @@ -282,8 +282,8 @@ public void PerformanceBaseline_CrossDomainCalculations()
double performance = MeasurePerformance(test.action, MediumIterationCount);
Console.WriteLine($"{test.name}: {performance:F0} ops/sec");

Assert.IsTrue(performance > 1000000,
$"Cross-domain performance regression: {test.name} = {performance:F0} ops/sec < 1M ops/sec");
Assert.IsTrue(performance > 500000,
$"Cross-domain performance regression: {test.name} = {performance:F0} ops/sec < 500K ops/sec");
}
}

Expand Down
Loading