Skip to content

캠퍼스맵 API 추가#732

Open
boiledeggg wants to merge 4 commits into
developfrom
feature/kuring-map-api
Open

캠퍼스맵 API 추가#732
boiledeggg wants to merge 4 commits into
developfrom
feature/kuring-map-api

Conversation

@boiledeggg

@boiledeggg boiledeggg commented Jul 25, 2026

Copy link
Copy Markdown
Member

요약

  • API DTO 추가
  • API 호출을 위한 Service 및 Client 인터페이스 추가
  • Place 도메인 모델 확장
  • PlaceRepository가 Service의 메서드를 호출하도록 확장

설명

  • 총 5개의 API가 추가되었습니다.
    1. 캠퍼스맵 건물 상세조회
    2. 캠퍼스맵 건물 키워드 검색
    3. 캠퍼스맵 전체 건물 목록 조회
    4. 캠퍼스맵 카테고리 기반 시설 목록 조회
    5. 캠퍼스맵 카테고리 목록 조회

Summary by CodeRabbit

  • 새로운 기능

    • 캠퍼스 건물 목록과 상세 정보를 조회할 수 있습니다.
    • 건물 이름으로 장소를 검색할 수 있습니다.
    • 캠퍼스 내 시설 정보를 카테고리별로 확인할 수 있습니다.
    • 장소 카테고리, 이미지, 위치, 수량, 외부 링크 정보를 제공합니다.
    • 운영 상태와 운영 시간을 더욱 정확하게 표시합니다.
  • 개선 사항

    • 건물과 시설 정보가 일관된 형식으로 제공됩니다.
    • 장소 조회 실패 시 오류 결과를 안정적으로 안내합니다.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@boiledeggg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ddede385-4222-466d-97cb-2b5f36705006

📥 Commits

Reviewing files that changed from the base of the PR and between accee4c and b2a77cf.

📒 Files selected for processing (5)
  • data/place/build.gradle.kts
  • data/place/src/main/java/com/ku_stacks/ku_ring/place/mapper/ResponseToDomain.kt
  • data/place/src/main/java/com/ku_stacks/ku_ring/place/repository/PlaceRepositoryImpl.kt
  • data/place/src/test/java/com/ku_stacks/ku_ring/place/PlaceRepositoryTest.kt
  • domain/place/src/main/java/com/ku_stacks/ku_ring/domain/place/repository/PlaceRepository.kt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/kuring-map-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@boiledeggg
boiledeggg force-pushed the feature/kuring-map-api branch from 942e82a to accee4c Compare July 25, 2026 08:32

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@data/place/src/main/java/com/ku_stacks/ku_ring/place/repository/PlaceRepositoryImpl.kt`:
- Around line 20-58: The suspend repository methods getPlaceBuildingDetail,
searchPlaceBuildings, getPlaceBuildings, getPlaceCampusPlaces, and
getPlaceCategories currently use runCatching, which absorbs coroutine
cancellation. Replace each wrapper with the shared suspendRunCatching helper
from Result.kt while preserving the existing response validation and domain
mapping logic.

In `@data/place/src/test/java/com/ku_stacks/ku_ring/place/PlaceRepositoryTest.kt`:
- Around line 18-26: PlaceRepositoryTest를 JUnit4의 RobolectricTestRunner와
org.junit 사용에서 JUnit5 기반 Robolectric 설정으로 전환하세요. 테스트 클래스의
`@RunWith`(RobolectricTestRunner::class)와 관련 JUnit4 어노테이션·임포트를 JUnit5 방식으로 교체하고,
PlaceClient Mockito mock과 기존 테스트 동작은 유지하세요.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b677591-956c-4b5f-8c8d-b53797aa3904

📥 Commits

Reviewing files that changed from the base of the PR and between 418d0d7 and accee4c.

📒 Files selected for processing (17)
  • data/domain/src/main/java/com/ku_stacks/ku_ring/domain/Place.kt
  • data/place/build.gradle.kts
  • data/place/src/main/java/com/ku_stacks/ku_ring/place/mapper/ResponseToDomain.kt
  • data/place/src/main/java/com/ku_stacks/ku_ring/place/repository/PlaceRepositoryImpl.kt
  • data/place/src/test/java/com/ku_stacks/ku_ring/place/PlaceRepositoryTest.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/PlaceClient.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/PlaceService.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/di/PlaceModule.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceBuildingDetailResponse.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceBuildingListResponse.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceBuildingResponse.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCampusPlaceListResponse.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCampusPlaceResponse.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCategoryListResponse.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCategoryResponse.kt
  • data/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceOperatingHoursResponse.kt
  • domain/place/src/main/java/com/ku_stacks/ku_ring/domain/place/repository/PlaceRepository.kt

@boiledeggg
boiledeggg force-pushed the feature/kuring-map-api branch from accee4c to b2a77cf Compare July 25, 2026 23:25
@boiledeggg
boiledeggg marked this pull request as ready for review July 25, 2026 23:26
@github-actions
github-actions Bot requested review from l2hyunwoo and mwy3055 July 25, 2026 23:26
@boiledeggg
boiledeggg requested a review from ikseong00 July 25, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant