캠퍼스맵 API 추가#732
Conversation
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
942e82a to
accee4c
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@data/place/src/main/java/com/ku_stacks/ku_ring/place/repository/PlaceRepositoryImpl.kt`:
- Around line 20-58: The suspend repository methods getPlaceBuildingDetail,
searchPlaceBuildings, getPlaceBuildings, getPlaceCampusPlaces, and
getPlaceCategories currently use runCatching, which absorbs coroutine
cancellation. Replace each wrapper with the shared suspendRunCatching helper
from Result.kt while preserving the existing response validation and domain
mapping logic.
In `@data/place/src/test/java/com/ku_stacks/ku_ring/place/PlaceRepositoryTest.kt`:
- Around line 18-26: PlaceRepositoryTest를 JUnit4의 RobolectricTestRunner와
org.junit 사용에서 JUnit5 기반 Robolectric 설정으로 전환하세요. 테스트 클래스의
`@RunWith`(RobolectricTestRunner::class)와 관련 JUnit4 어노테이션·임포트를 JUnit5 방식으로 교체하고,
PlaceClient Mockito mock과 기존 테스트 동작은 유지하세요.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b677591-956c-4b5f-8c8d-b53797aa3904
📒 Files selected for processing (17)
data/domain/src/main/java/com/ku_stacks/ku_ring/domain/Place.ktdata/place/build.gradle.ktsdata/place/src/main/java/com/ku_stacks/ku_ring/place/mapper/ResponseToDomain.ktdata/place/src/main/java/com/ku_stacks/ku_ring/place/repository/PlaceRepositoryImpl.ktdata/place/src/test/java/com/ku_stacks/ku_ring/place/PlaceRepositoryTest.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/PlaceClient.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/PlaceService.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/di/PlaceModule.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceBuildingDetailResponse.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceBuildingListResponse.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceBuildingResponse.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCampusPlaceListResponse.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCampusPlaceResponse.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCategoryListResponse.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceCategoryResponse.ktdata/remote/src/main/java/com/ku_stacks/ku_ring/remote/place/response/PlaceOperatingHoursResponse.ktdomain/place/src/main/java/com/ku_stacks/ku_ring/domain/place/repository/PlaceRepository.kt
accee4c to
b2a77cf
Compare
요약
설명
Summary by CodeRabbit
새로운 기능
개선 사항