fix(render): use portable paths for embedded templates#503
Open
BittuBarnwal7479 wants to merge 1 commit into
Open
fix(render): use portable paths for embedded templates#503BittuBarnwal7479 wants to merge 1 commit into
BittuBarnwal7479 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fix built-in Helm and Terraform template discovery on Windows by using
path.Joininstead offilepath.Joinfor paths consumed byembed.FS.embed.FSimplements Go'sio/fs, which always expects forward-slash (/) separated paths regardless of the operating system. This change restores correct template loading on Windows while preserving existing behavior on Linux and macOS.🧩 Type of change
No. This only fixes Windows compatibility for embedded template discovery and does not change generated artifacts or catalog contents.
🧪 Testing
🔗 Related Issues / Tickets
Fixes: #502
✅ Checklist
📎 Additional Context (optional)
Before:

After:
