fix: refresh binding status when work is first observed with reported status#567
Open
Asish Kumar (officialasishkumar) wants to merge 1 commit into
Conversation
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR makes the work generator recover when its cache first observes a
Workobject after the member side has already reported status. In that case the create event now requeues the parent binding so the binding and placement status can be refreshed instead of remaining stuck atApplyInProgress.To avoid changing the normal fresh-work flow, the create handler only enqueues when the created
Workalready carries reported status.Fixes #558
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
go test ./pkg/controllers/workgenerator -run TestWorkHandlerCreateFunc -count=1go test ./pkg/controllers/workgenerator -run TestGetWorkNamePrefixFromSnapshotName -count=1Special notes for your reviewer
Workobjects that already have reported status to avoid regressing the existingApplyInProgressbehavior for freshly created works without member-side status yet.